After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752220 - GTKFileChooser should provide a shortcut for focus the file list
GTKFileChooser should provide a shortcut for focus the file list
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
3.22.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-07-10 12:37 UTC by chris
Modified: 2018-05-02 16:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot of the old GTK2 filechooser (firefox) (83.30 KB, image/png)
2015-08-05 16:35 UTC, chris
Details

Description chris 2015-07-10 12:37:28 UTC
Hi all,

it would be helpfull if the GTKFileChooser provides a shortcut for focusing the "file entry table" 
so you could easily jump beween places/ locationbar and files table.
this would the filechooser realy more accessible for keyboard users :).
Comment 1 Matthias Clasen 2015-07-11 05:48:58 UTC
Using left/right arrow keys lets you go between places and files
Comment 2 chris 2015-07-16 08:40:58 UTC
I think its more efficient having a shortcut to jump to the basic operation panels. And selecting a folder is very the very basic work for this dialog :).
For example i m blind. arrowing arround sometimes bring me to place where i wont go to ^^. I overwrite inadvertently a file more than once due those problems :/.
Tab is not the best at all in the dialog (because the location bar blocks tab and so on..
so it would realy smart if i just can jumpt between Places -> Files ->  Locationbar (for setting a filename in save as).
thats my typical workflow for saving a file.

it would a big improve in a11y case for me and for sure also for other people like me
Comment 3 Matthias Clasen 2015-08-03 15:50:14 UTC
Its a bit awkward to add a mnemonic without a visible label to show it. I've only added Alt-P for compatibility with gtk2, where we have a visible Places label. Even in gtk2, we didn't have a 'focus file list' shortcut, though.

I'm open for suggestions. Maybe Alt-N would work, using the 'Name' in the column header as mnemonic. For now, the best workaround is probably "Alt-P left-arrow"
Comment 4 chris 2015-08-05 16:35:35 UTC
Created attachment 308805 [details]
screenshot of the old GTK2 filechooser (firefox)

Hi
The "Gtk2" places memonic was also only indicated by the column name. If you press ALT (see red mark on my screenshot Orte = Places in german).

I found your idea a good solution and it improves the Keyboard Nav really and it is more consistent because i can jump anywhere i like.
But: 
Alt + N is in the GTK 3.16 used for the "_Name" label in the location bar. I think it should be unique ( see green mark on my screenshot). Maybe ALT + m for the Na_me or Alt + E for Nam_e.

what do you think about?
Comment 5 Matthias Clasen 2015-08-06 12:23:28 UTC
Turns out just making the list header have a mnemonic does not quite work - activating the mnemonic has the side effect of activating the list header button, which toggles the sort order. So, some extra work is required here.
Comment 6 texou 2017-01-06 18:28:55 UTC
Hi,

I'm blind and after dialog on screen reader mailing list, I believe most blind people have pain with this dialog (Open and Save ones).

The main problem if that beyond ctrl-l, we haven't a lot of bindings to access to various areas, that is not necessarily a problem. However, if not binding, movement with arrow keys and tab should be more understandable. Here, it is not. :)

Let's compare how it works on Windows or LibreOffice-specific dialogs:
- ctrl-o
- tab switches between various areas (name, location, file & dir list, file type)
- Arrow keys change the selected in the box
In GTK2:
- ctrl-o;
- tab and shift-tab enabled to switch between various locations. It was not really friendly, but after efforts, user could have success if he remembered the order of boxes.

Now, I'm unable to choose preperly a location to search, and a file to open. Because I don't know how to have such lists. Right/left keys go to some strange areas (recent file, files). But up-down keys have limited effect. Tab never goes to this list.

Well, it's confusing. Do you have tips to use the box just with keyboard properly? Or is some change needed to improve its usability with keyboard?

Best regards,
Comment 7 chris 2017-08-15 12:41:36 UTC
(In reply to texou from comment #6)
> Hi,
> 
> I'm blind and after dialog on screen reader mailing list, I believe most
> blind people have pain with this dialog (Open and Save ones).
> 
> The main problem if that beyond ctrl-l, we haven't a lot of bindings to
> access to various areas, that is not necessarily a problem. However, if not
> binding, movement with arrow keys and tab should be more understandable.
> Here, it is not. :)
> 
> Let's compare how it works on Windows or LibreOffice-specific dialogs:
> - ctrl-o
> - tab switches between various areas (name, location, file & dir list, file
> type)
> - Arrow keys change the selected in the box
> In GTK2:
> - ctrl-o;
> - tab and shift-tab enabled to switch between various locations. It was not
> really friendly, but after efforts, user could have success if he remembered
> the order of boxes.
> 
> Now, I'm unable to choose preperly a location to search, and a file to open.
> Because I don't know how to have such lists. Right/left keys go to some
> strange areas (recent file, files). But up-down keys have limited effect.
> Tab never goes to this list.
> 
> Well, it's confusing. Do you have tips to use the box just with keyboard
> properly? Or is some change needed to improve its usability with keyboard?
> 
> Best regards,

Full agreee,
my girlfrind is also blind and its nearby impossible to use this dialog without overwriting files by accident.
my memonic idea is also just an workarround to be able jump to areas without selecting anything else (that change the filename she entered).
its all realy hard to navigate and see whats going on if you dont see...

cheers chrys
Comment 8 Alexis BRENON 2017-10-19 12:40:17 UTC
Hi,

+1

I'm not blind but like to use my keyboard a lot on my laptop, and this dialog window is really not intuitive. For example, depending on the current selected place, right arrow send me sometimes to Location Bar (for upper places) or the files pane (for lower places).

As stated by texou, I think that it should be great to stick to something like:
 * [Shift-]Tab cycles through areas (Places, Location bar, Files, Open/Save/Cancel buttons)
 * Arrow keys allow moves in the currently selected area.

Kind regards,
Alexis.
Comment 9 Daniel Boles 2018-04-08 14:45:19 UTC
workaround: focus the location entry with Ctrl+L, then hit Esc; the focus then goes into the file list (and the 1st item therein)
Comment 10 GNOME Infrastructure Team 2018-05-02 16:39:01 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/562.