After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752206 - element: pad leak during failures.
element: pad leak during failures.
Status: RESOLVED DUPLICATE of bug 747990
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-10 06:36 UTC by Vineeth
Modified: 2015-07-10 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pad leak during failures (1.09 KB, patch)
2015-07-10 06:37 UTC, Vineeth
none Details | Review

Description Vineeth 2015-07-10 06:36:00 UTC
In case of gst_element_add_pad
when the pad being added already has a parent or same name already exists,
it fails, but gst_element_add_pad is supposed to take the reference of the buffer and the caller assumes so, which will lead to leaking of pad.

unref'ing the pad on failures.
Comment 1 Vineeth 2015-07-10 06:37:43 UTC
Created attachment 307196 [details] [review]
pad leak during failures
Comment 2 Sebastian Dröge (slomo) 2015-07-10 07:49:43 UTC
Same goes for gst_bin_add() btw :) Want to provide a patch for both?

*** This bug has been marked as a duplicate of bug 747990 ***
Comment 3 Luis de Bethencourt 2015-07-10 09:15:25 UTC
Go for it Vineeth :) provide a patch for both.