After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752164 - Transition to libsystemd
Transition to libsystemd
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-09 10:51 UTC by Michael Biebl
Modified: 2015-07-14 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: transition to libsystemd (1.08 KB, patch)
2015-07-09 10:59 UTC, Michael Biebl
accepted-commit_now Details | Review

Description Michael Biebl 2015-07-09 10:51:52 UTC
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779769

In systemd v209, released over a year ago, the various libsystemd-* libraries
(libsystemd-journal.so, libsystemd-login.so, libsystem-daemon.so,
libsystemd-id128.so) were merged into a single libsystemd.so library to reduce
code duplication and avoid cyclic dependencies [1].

Your package declares a build-dependency on either libsystemd-daemon-dev,
libsystemd-login-dev or libsystemd-journal-dev.

Please update your package so it can be built against libsystemd.


Updating the configure check / build system
===========================================
If your package use pkg-config and autotools, a typical configure check
looks like:

 PKG_CHECK_MODULES(FOO, libsystemd-login)
All you need to do, is change that to
 PKG_CHECK_MODULES(FOO, libsystemd)


If there are checks for libsystemd-journal, libsystemd-login and
libsystemd-journal, you can merge that into a single check:

 PKG_CHECK_MODULES(FOO, libsystemd-login)
 PKG_CHECK_MODULES(BAR, libsystemd-daemon)
 PKG_CHECK_MODULES(BAZ, libsystemd-journal)
=>
 PKG_CHECK_MODULES(FOO, libsystemd)

BAR_{CFLAGS,LIBS} and BAZ_{CFLAGS,LIBS} need to be updated accordingly.

If you/upstream wants to support building against older versions of systemd,
you can update the configure check as follows:

 PKG_CHECK_MODULES(FOO, libsystemd-login)
=>
 PKG_CHECK_MODULES(FOO, libsystemd,, [PKG_CHECK_MODULES(FOO, libsystemd-login)])

See [2] as an example how to do that.





[1] http://lists.freedesktop.org/archives/systemd-devel/2014-February/017146.html
[2] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=8f6317f88a3ca3f42cf72137bb033b4a020b7b82
Comment 1 Michael Biebl 2015-07-09 10:59:13 UTC
Created attachment 307136 [details] [review]
build: transition to libsystemd

The attached patch uses the new name for the libsystemd pc file.

It doesn't add any fallbacks for systemd < 209. It also doesn't merge the journal configure check, so journal support can still enabled/disabled separately.
Comment 2 Ray Strode [halfline] 2015-07-14 14:46:08 UTC
Comment on attachment 307136 [details] [review]
build: transition to libsystemd

hmm, odd, i thought we already did this a while ago. must have been gnome-session or something.
Comment 3 Michael Biebl 2015-07-14 15:09:15 UTC
Thanks for the review. Committed as eee5bf7