After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752073 - Revert "imagefreeze: Remove impossible error condition"
Revert "imagefreeze: Remove impossible error condition"
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2015-07-07 13:00 UTC by Vineeth
Modified: 2015-08-16 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

revert d46631c5c7312ad613397f8238c7a9714ae3ae94 (1.37 KB, patch)
2015-07-07 13:01 UTC, Vineeth
committed Details | Review

Description Vineeth 2015-07-07 13:00:07 UTC
This reverts commit d46631c5c7312ad613397f8238c7a9714ae3ae94.

The change made in the above commit is not proper.
pad only handle EOS event but not EOS flow, and   
will push the buffer again which will result in assertion error.
So we should not handle the buffer again and return EOS flow.
Comment 1 Vineeth 2015-07-07 13:01:37 UTC
Created attachment 307005 [details] [review]
revert d46631c5c7312ad613397f8238c7a9714ae3ae94
Comment 2 Luis de Bethencourt 2015-07-07 14:57:45 UTC
Review of attachment 307005 [details] [review]:

Thanks Vineeth :)