After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752059 - xvimagesink: refactor to use gst_pad_push_event
xvimagesink: refactor to use gst_pad_push_event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal enhancement
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-07 10:55 UTC by Vineeth
Modified: 2015-08-16 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
refactor code (5.37 KB, patch)
2015-07-07 10:57 UTC, Vineeth 		committed Details | Review

Description Vineeth 2015-07-07 10:55:37 UTC 
Right now navigation events are being sent via gst_pad_send_event
after getting the peer pad of the sinkpad.
But the same functionality can be done using gst_pad_push_event
without need of getting peer pad in xvimagesink.
Comment 1 Vineeth 2015-07-07 10:57:48 UTC 
Created attachment 306995 [details] [review]
refactor code
Comment 2 Luis de Bethencourt 2015-07-07 11:27:24 UTC 
Looks good to me.

Will keep it open for a short while in case anybody wants to add anything. If not, I will merge.
Comment 3 Luis de Bethencourt 2015-07-07 11:50:58 UTC 
Review of attachment 306995 [details] [review]:

commit efdb0fc28181b86a340db933c5a9f0ca9ce92382
Author: Vineeth T M <vineeth.tm@samsung.com>
Date:   Tue Jul 7 19:55:44 2015 +0900

    xvimagesink: refactor to use gst_pad_push_event

    Right now navigation events are being sent via gst_pad_send_event
    after getting the peer pad of the sinkpad.
    But the same functionality can be done using gst_pad_push_event
    without need of getting peer pad in xvimagesink.

    https://bugzilla.gnome.org/show_bug.cgi?id=752059