After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752049 - Fix return value error in camel_imapx_job_inc_update_locked
Fix return value error in camel_imapx_job_inc_update_locked
Product: evolution-data-server
Classification: Platform
Component: general
3.17.x (obsolete)
Other FreeBSD
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Reported: 2015-07-07 07:39 UTC by Ting-Wei Lan
Modified: 2015-07-09 14:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

[PATCH] Bug 752049 - Fix return value error in camel_imapx_job_inc_update_locked (828 bytes, patch)
2015-07-07 07:41 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2015-07-07 07:39:55 UTC
Please see the patch. There is a return value error in camel/providers/imapx/camel-imapx-job.c, function camel_imapx_job_inc_update_locked.
Comment 1 Ting-Wei Lan 2015-07-07 07:41:20 UTC
Created attachment 306977 [details] [review]
[PATCH] Bug 752049 - Fix return value error in camel_imapx_job_inc_update_locked
Comment 2 Milan Crha 2015-07-07 18:17:50 UTC
Thanks for a bug report and patch. You are right. I'd like to know why I do not get notified about such issues by the compiler. I get warnings for such silly mistakes in other parts in the code. Weird. In any case, I committed your change.

Created commit bf0b221 in eds master (3.17.4+)
Created commit e1a6568 in eds gnome-3-16 (3.16.4+)
Comment 3 Ting-Wei Lan 2015-07-08 15:40:25 UTC
This problem is caught by clang. Clang shows this problem as error, so we can easily find it. GCC may be able to catch the problem using -Wreturn-type, but it seems there are still some kinds of return value error cannot be caught by GCC. I remember that GCC 5 can show warnings for return value problems without adding arguments, but I don't check whether GCC 5 is able to catch all return value problems that clang shows as error by default.
Comment 4 Milan Crha 2015-07-09 14:18:26 UTC
Yeah, GCC is cheating on me in this regard, even with that -Wreturn-type, which I tried earlier today. Bad luck for me.