After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752044 - Warn and ignore return annotations when there is no return value
Warn and ignore return annotations when there is no return value
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: g-ir-scanner
2.43.x
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-07-07 01:53 UTC by Garrett Regier
Modified: 2015-10-04 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
scanner: Warn and ignore return annotations when there is no return value (2.39 KB, patch)
2015-07-07 01:55 UTC, Garrett Regier 		none Details | Review
scanner: Warn and ignore return annotations when there is no return value v2 (3.23 KB, patch)
2015-07-07 04:12 UTC, Garrett Regier 		accepted-commit_now Details | Review

Description Garrett Regier 2015-07-07 01:53:02 UTC 
Currently return annotations are allowed when there is no return value. This can cause the .gir to contain invalid data which would likely cause a crash.
Comment 1 Garrett Regier 2015-07-07 01:55:06 UTC 
Created attachment 306969 [details] [review]
scanner: Warn and ignore return annotations when there is no return value
Comment 2 Garrett Regier 2015-07-07 04:12:48 UTC 
Created attachment 306974 [details] [review]
scanner: Warn and ignore return annotations when there is no return value v2

Updated codegen to avoid writing docs for non-existent return values, this was breaking the everything tests. They should really get generated more often...
Comment 3 Emmanuele Bassi (:ebassi) 2015-07-07 07:47:36 UTC 
Review of attachment 306974 [details] [review]:

Looks good.