After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752043 - ximagesink: Post navigation events as message on the bus
ximagesink: Post navigation events as message on the bus
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal enhancement
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 752041
Blocks:
 
 
Reported: 2015-07-07 00:58 UTC by Vineeth
Modified: 2015-08-16 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
post unhandled navigation events on bus (1.58 KB, patch)
2015-07-07 00:59 UTC, Vineeth 		none Details | Review
post unhandled navigation events on bus (1.52 KB, patch)
2015-07-07 10:48 UTC, Vineeth 		committed Details | Review

Description Vineeth 2015-07-07 00:58:28 UTC 
post unhandled events to bus, so that 
application can utilise the same if needed

This is actually same as https://bugzilla.gnome.org/show_bug.cgi?id=747245 in xvimagesink. Adding the same to ximagesink
Comment 1 Vineeth 2015-07-07 00:59:34 UTC 
Created attachment 306968 [details] [review]
post unhandled navigation events on bus
Comment 2 Luis de Bethencourt 2015-07-07 10:00:55 UTC 
Looks good to me. Will test and merge if it works well.
Comment 3 Sebastian Dröge (slomo) 2015-07-07 10:15:37 UTC 
Review of attachment 306968 [details] [review]:

::: sys/ximage/ximagesink.c
@@ +1575,3 @@
+  if (!handled && event) {
+    gst_element_post_message ((GstElement *) ximagesink,
+        gst_navigation_message_new_event ((GstObject *) ximagesink, event));

GST_ELEMENT_CAST() and GST_OBJECT_CAST(), otherwise looks ok
Comment 4 Luis de Bethencourt 2015-07-07 10:32:59 UTC 
Vineeth,

Send a new version with Sebastian's suggestion and I will merge this.
Comment 5 Vineeth 2015-07-07 10:48:49 UTC 
Created attachment 306993 [details] [review]
post unhandled navigation events on bus

This is dependant on https://bugzilla.gnome.org/show_bug.cgi?id=752041.

Made slight changes along with the review comments based on the changed made in the other bug
Comment 6 Luis de Bethencourt 2015-07-07 11:00:02 UTC 
Review of attachment 306993 [details] [review]:

commit 51019c16e16d1860491840774b2521173440349e
Author: Vineeth T M <vineeth.tm@samsung.com>
Date:   Tue Jul 7 19:45:43 2015 +0900

    ximagesink: Post navigation events as message on the bus

    post unhandled events to bus, so that
    application can utilise the same if needed

    https://bugzilla.gnome.org/show_bug.cgi?id=752043