After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752037 - GIO services need a helper for opening output stream
GIO services need a helper for opening output stream
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2015-07-06 21:25 UTC by Martin Blanchard
Modified: 2015-09-30 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
New gegl_gio_open_output_stream() function (2.76 KB, patch)
2015-07-06 21:27 UTC, Martin Blanchard 		none Details | Review
Fix output stream opening for Win32 (2.94 KB, patch)
2015-09-26 10:40 UTC, Martin Blanchard 		committed Details | Review

Description Martin Blanchard 2015-07-06 21:25:31 UTC 
In order to port saving operations to GIO, gegl-gio should ship an output stream opening helper, like gegl_gio_open_input_stream() is doing for input ones.
Comment 1 Martin Blanchard 2015-07-06 21:27:23 UTC 
Created attachment 306961 [details] [review]
New gegl_gio_open_output_stream() function
Comment 2 Martin Blanchard 2015-09-26 10:40:53 UTC 
Created attachment 312188 [details] [review]
Fix output stream opening for Win32

New version, fixing stupid error for Win32...
Comment 3 Jon Nordby 2015-09-28 11:55:18 UTC 
Agreed we should have this convenience also for output. It would be great to have at least one op ported to it though, so we're not adding unused/untested code..
Comment 4 Martin Blanchard 2015-09-28 14:05:30 UTC 
Sure. I'm currently working on a TIFF saver which uses this. See bug #739124 (should probably be marked as depending on 752037).
Comment 5 Martin Blanchard 2015-09-28 14:09:26 UTC 
However, I've never tested the Win32 part of this patch, as the mistake in the initial version let you guess...
Comment 6 Jon Nordby 2015-09-30 14:22:26 UTC 
Good there is code to use it. We do have others using GEGL master on Windows quasi-regularly, so issues specific to that platform tends to work out.

Committed to master now. Thanks!

commit af4368284e35ad134cde80e762f05e651a746edb
Author: Martin Blanchard <tchaik@gmx.com>
Date:   Sat Sep 26 12:32:50 2015 +0200

    gegl-gio: Add a helper for opening output stream
    
    Similarly to what gegl_gio_open_input_stream() does for input streams,
    this adds a gegl_gio_open_ouput_stream(), allowing one to open an
    output stream from a URI or path.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752037
Comment 7 Jon Nordby 2015-09-30 14:26:57 UTC 
Review of attachment 312188 [details] [review]:

Mark committed.