After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752029 - (allow-none) on a return value is broken
(allow-none) on a return value is broken
Status: RESOLVED OBSOLETE
Product: gobject-introspection
Classification: Platform
Component: g-ir-scanner
2.43.x
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-07-06 18:39 UTC by Garrett Regier
Modified: 2018-02-08 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
scanner: Fix allow-none on return values (12.11 KB, patch)
2015-07-06 18:46 UTC, Garrett Regier 		reviewed Details | Review

Description Garrett Regier 2015-07-06 18:39:26 UTC 
This can be seen in the regress tests, regress_test_ghash_null_return has the (allow-none) annotation on the return value but it does not get emitted to the gir. This is due to a broken check which is causing optional to be set instead which is invalid for return values.

https://git.gnome.org/browse/gobject-introspection/tree/tests/scanner/regress.c#n1212
https://git.gnome.org/browse/gobject-introspection/tree/tests/scanner/Regress-1.0-expected.gir#n5677
Comment 1 Garrett Regier 2015-07-06 18:46:12 UTC 
Created attachment 306945 [details] [review]
scanner: Fix allow-none on return values

The optional annotation was being applied which is invalid for return values.
Comment 2 Colin Walters 2015-09-30 03:48:43 UTC 
Review of attachment 306945 [details] [review]:

Hum...but isn't the default for return values to be nullable?
Comment 3 GNOME Infrastructure Team 2018-02-08 12:36:06 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gobject-introspection/issues/136.