if someone was going to-do this, please can you shout loudly a long time in advance (e.g. via RB mailing list) so that external plugins that depend upon webkitgtk-3.0 have a chance to be updated.

For example, my coverart-browser plugin does have a number of webkit dependencies that probably will need to be revisited/reworked.

thanks

We shouted two years ago that WebKit1 is deprecated, and a year ago when we deleted it upstream; now we're trying to remove it from GNOME, this should not be any surprise.

Michael - I was referring to when (or if?) rhythmbox moves.  I only subscribe to RB's mailing list and dont remember seeing a message about webkit being replaced with webkit2.

I maybe wrong (please say if I am) - but I dont think webkit and webkit2 can co-exist together thus I cant change my plugin until rhythmbox makes its change and would need an appreciable amount of time to uplift.

That's correct, you can't use two different versions of WebKit in the same process, so all the RB plugins must be ported at the same time. In this bug we'll track in-tree plugins.

rhythmbox is going to stop using webkit entirely pretty soon.

Jonathan - ok.  Thanks for the info.

I presume that means the context pane plugin is going to be removed?

That's one possibility.

(In reply to Jonathan Matthew from comment #5)
> rhythmbox is going to stop using webkit entirely pretty soon.

Hey Jonathan, what are your plans for this? It seems like a port to WK2 would not be a worthwhile endeavor, since you plan to stop using WK entirely.

I am working on removing WK1 from the default install in Fedora Workstation; that means building Rhythmbox with --disable-webkit. Does this sound OK? Would you rather make that change upstream? Are you ready to rip out the WK plugins entirely?

Created attachment 318480 [details] [review]
Port rb-podcast-properties-dialog to webkit2

I worked on a port before I found this bug. I'm trying to achieve the same goal
for Ubuntu. Maybe it's useful if you're not ready with whatever webkit
replacement you have in mind..

I could look at the context plugin but it seems generally a bit broken even
with wk1 so I would prefer to remove it. Can give (or commit) a patch if you
want that.

Thanks a bunch Iain! If this patch is working well for Ubuntu then I think we can use this in Fedora as well, until it makes it into a released Rhythmbox.

I'm adding your patch to rawhide. If people file bugs against it then we'll switch to using --disable-webkit.

See bug #686373 for our meta tracking bug.

(In reply to Michael Catanzaro from comment #11)
> I'm adding your patch to rawhide. If people file bugs against it then we'll
> switch to using --disable-webkit.

Cool, thanks!

Just to be clear - make sure you don't ship the context plugin as that is unported and it'll probably make RB crash.

Yes, I added this little patch:

diff --git a/plugins/Makefile.am b/plugins/Makefile.am
index bea62b2..5f60c6a 100644
--- a/plugins/Makefile.am
+++ b/plugins/Makefile.am
@@ -24,10 +24,6 @@ SUBDIRS +=						\
 	soundcloud					\
 	rb
 
-if WITH_WEBKIT
-SUBDIRS += context
-endif
-
 endif # ENABLE_PYTHON
 
 if WITH_LIRC
--

By the way, we're tentatively throwing around plans to remove WebKit1 mid-year, as a response to [1]. I'm not sure if it will happen, since that will require removing many apps, but looks like Rhythmbox will be safe regardless. :)

[1] http://webkitgtk.org/security/WSA-2015-0002.html

This patch is being applied downstream in both Ubuntu 16.04 and Fedora 24, any interest in accepting it?

it would be great to get this fixed, indeed

Review of attachment 318480 [details] [review]:

I still haven't finished my replacement for the podcast properties dialog, so I'm committing this.

I've also disabled the context pane plugin.