After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752011 - video: Add boxed type for GstVideoInfo structure
video: Add boxed type for GstVideoInfo structure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-06 09:47 UTC by Marcin Kolny (IRC: loganek)
Modified: 2015-08-16 13:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.65 KB, patch)
2015-07-06 09:47 UTC, Marcin Kolny (IRC: loganek) 		committed Details | Review

Description Marcin Kolny (IRC: loganek) 2015-07-06 09:47:09 UTC 
Created attachment 306900 [details] [review]
patch

Hi,
attached patch with implementation boxed type for GstVideoInfo structure
Comment 1 Sebastian Dröge (slomo) 2015-07-06 09:55:02 UTC 
I added some "Since: 1.6" markers to the docs

commit 95fa0c58a29b9a9b94cfd80bb843b9c12fdb2870
Author: Marcin Kolny <marcin.kolny@flytronic.pl>
Date:   Mon Jul 6 11:36:58 2015 +0200

    video-info: implement GstVideoInfo as boxed type
    
    GstVideoInfo usually is created on the stack, but boxed type can be useful
    for bindings.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752011
Comment 2 Nicolas Dufresne (ndufresne) 2015-07-06 12:02:53 UTC 
Review of attachment 306900 [details] [review]:

Please, don't merge new APIs without updating the documentation. It's very hard to find after ward. All the Since marker are missing and the documentation is not update. Please provide a patch.

::: gst-libs/gst/video/video-info.c
@@ +36,3 @@
+ * Copy a GstVideoInfo structure.
+ *
+ * Returns: a new #GstVideoInfo. free with gst_video_info_free.

Missing Since.

@@ +49,3 @@
+ *
+ * Free a GstVideoInfo structure previously allocated with gst_video_info_new()
+ * or gst_video_info_copy().

Missing Since.

@@ +66,3 @@
+ * gst_video_info_init().
+ *
+ * Returns: a new #GstVideoInfo. free with gst_video_info_free().

Missing Since.
Comment 3 Sebastian Dröge (slomo) 2015-07-06 12:34:37 UTC 
Read more closely my comment here. I added the "Since" markers to the docs before merging.

And we don't add documentation for the standard GObject macros.
Comment 4 Nicolas Dufresne (ndufresne) 2015-07-06 13:51:05 UTC 
Commit: bf23f44239b596c8b6cece52d9b0edc5c1e8e27b
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=bf23f44239b596c8b6cece52d9b0edc5c1e8e27b

Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Jul  6 15:36:07 2015 +0300

docs: Add new symbols to the docs and .def files