After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752007 - Some of Machine's methods should be properties
Some of Machine's methods should be properties
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-07-06 07:25 UTC by Adrien Plazas
Modified: 2016-09-20 08:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
machine: is_connected() -> prop (1.93 KB, patch)
2015-07-06 07:30 UTC, Adrien Plazas 		none Details | Review
machine: is_running() -> prop (4.92 KB, patch)
2015-07-06 07:30 UTC, Adrien Plazas 		none Details | Review
machine: is_on() -> prop (3.55 KB, patch)
2015-07-06 07:30 UTC, Adrien Plazas 		none Details | Review
machine: is_connected() -> prop (1.93 KB, patch)
2015-07-06 12:48 UTC, Adrien Plazas 		accepted-commit_now Details | Review
machine: is_running() -> prop (4.92 KB, patch)
2015-07-06 12:48 UTC, Adrien Plazas 		accepted-commit_now Details | Review
machine: is_on() -> prop (3.55 KB, patch)
2015-07-06 12:48 UTC, Adrien Plazas 		accepted-commit_now Details | Review
machine: is_connected() -> prop (1.94 KB, patch)
2015-07-06 13:12 UTC, Adrien Plazas 		committed Details | Review
machine: is_running() -> prop (4.87 KB, patch)
2015-07-06 13:12 UTC, Adrien Plazas 		committed Details | Review
machine: is_on() -> prop (3.55 KB, patch)
2015-07-06 13:12 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2015-07-06 07:25:28 UTC 
Machine.is_connected(), Machine.is_running() and Machine.is_on() should be properties like the can_* properties to keep the way a Machine's state is checked consistent.
Comment 1 Adrien Plazas 2015-07-06 07:30:10 UTC 
Created attachment 306895 [details] [review]
machine: is_connected() -> prop

This is needed to make how the machine's state is checked consistent.
Comment 2 Adrien Plazas 2015-07-06 07:30:16 UTC 
Created attachment 306896 [details] [review]
machine: is_running() -> prop

This is needed to make how the machine's state is checked consistent.
Comment 3 Adrien Plazas 2015-07-06 07:30:21 UTC 
Created attachment 306897 [details] [review]
machine: is_on() -> prop

This is needed to make how the machine's state is checked consistent.
Comment 4 Adrien Plazas 2015-07-06 12:48:44 UTC 
Created attachment 306915 [details] [review]
machine: is_connected() -> prop

This is needed to make how the machine's state is checked consistent.
Comment 5 Adrien Plazas 2015-07-06 12:48:49 UTC 
Created attachment 306916 [details] [review]
machine: is_running() -> prop

This is needed to make how the machine's state is checked consistent.
Comment 6 Adrien Plazas 2015-07-06 12:48:54 UTC 
Created attachment 306917 [details] [review]
machine: is_on() -> prop

This is needed to make how the machine's state is checked consistent.
Comment 7 Zeeshan Ali 2015-07-06 13:00:33 UTC 
Review of attachment 306915 [details] [review]:

a ',' before "consistent" would slightly improve readability.
Comment 8 Zeeshan Ali 2015-07-06 13:02:02 UTC 
Review of attachment 306916 [details] [review]:

same comment on log.
Comment 9 Zeeshan Ali 2015-07-06 13:02:43 UTC 
Review of attachment 306917 [details] [review]:

same
Comment 10 Adrien Plazas 2015-07-06 13:12:28 UTC 
Created attachment 306918 [details] [review]
machine: is_connected() -> prop

This is needed to make how the machine's state is checked, consistent.
Comment 11 Adrien Plazas 2015-07-06 13:12:33 UTC 
Created attachment 306919 [details] [review]
machine: is_running() -> prop

This is needed to make how the machine's state is checked, consistent.
Comment 12 Adrien Plazas 2015-07-06 13:12:38 UTC 
Created attachment 306920 [details] [review]
machine: is_on() -> prop

This is needed to make how the machine's state is checked, consistent.
Comment 13 Zeeshan Ali 2015-07-07 17:33:22 UTC 
Patches rebased, their shortlog slightly modified and pushed.