GNOME Bugzilla – Bug 752001
region and language dialog isn't usable using the keyboard alone
Last modified: 2015-07-07 16:59:30 UTC
in the region andlanguage dialogin gnome control center, the dialog is accessible and navigable using the keyboard. However, the buttons and list items only activate if clicked on with the mouse. Pressing enter on the list items activates the "done" button, preventing keyboard only users from changing the language. This also affects the formats dialog, though the input source dialog works fine. A suggested fix would be to first press space bar on the item, language, format, etc to first mark it as active and then press enter to activate the done button.
There's multiple dialogs in this panel...you seem to be talking about the dialogs that come up when you activate Language or Formats (not the for adding input methods). You're right that Enter just activates the Done button there. But what you are suggesting as the 'fix' is what works today: spacebar changes the selected item and activates the ... row. I would suggest a more intuitive fix would be to make Enter only activate the Done button if the focus is on the row currently marked as selected, and activate the current row, otherwise.
I agree with Matthias's proposal.
This works for me. I'm not picky, so long as the dialog is usable using the keyboard. I'll even write up the documentation for it if you like, though it's probably not much more than, if you're using a keyboard, first press space before pressing the done button.
wait, scratch that. I should've read all the comments. Make that, when you change the language, press enter when done, which is already documented, so no additional docs are needed.
Created attachment 307020 [details] [review] common: Return the dialog if the activated row was already selected This makes the dialog a bit friendlier to use.
Created attachment 307021 [details] [review] region: Return the dialog if the activated row was already selected This makes the dialog a bit friendlier to use.
Created attachment 307022 [details] [review] region: Only return the dialog on enter if focus is on selected row This makes the dialog easier to use via keyboard navigation since otherwise we'd just return with the current selection on enter when the user actually intended to change the selection.
Created attachment 307023 [details] [review] common: Only return the dialog on enter if focus is on selected row This makes the dialog easier to use via keyboard navigation since otherwise we'd just return with the current selection on enter when the user actually intended to change the selection.
Review of attachment 307020 [details] [review]: > Return the dialog if the activated row was already selected I don't understand what this means.
Review of attachment 307021 [details] [review]: Same problem with the subject.
Review of attachment 307022 [details] [review]: What's "returning the dialog"? Looks good otherwise.
Review of attachment 307023 [details] [review]: Ditto.
Adjusted commit messages as agreed on IRC and pushed to both master and 3.16