GNOME Bugzilla – Bug 751889
baseparse: Calculates bitrates for the complete stream instead of windowed average
Last modified: 2018-11-03 12:28:19 UTC
See summary. Problem with that is that it will not react properly to bitrate changes currently.
But by doing so, we might break application assumptions. They might expect to get the overall average right before EOS. Apart from that we should just make that avg = (N * avg + new_frame_size) / (N + 1). Maybe with N = 127 or a similarly high number.
That actually does not work well as we might have many frames with unknown duration and only every now and then a smaller frame with timestamps. However the unknown durations should be considered too. So we would need a real running average of e.g. all measurements in the last 10 seconds or so, which is of course a bit more expensive to calculate.
>Calculates bitrates for the complete stream instead of windowed average This may not be good idea if the stream is live stream, currently on 1.8 i am playing a live stream overnight and i see few GStreamer-CRITICAL **: _gst_util_uint64_scale_int: assertion 'denom > 0' failed when it try to find the diffavg i believe accumulating duration and data_bytecount causes them to overflow at certain time. live stream url: http://bbcmedia.ic.llnwd.net/stream/bbcmedia_6music_mf_p?s=1464101370&e=1464115770&h=99703e730266d812bc9b95d30389c6b4
Do you want to work on a patch for that?
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/119.