After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751841 - dashdemux: segment timestamp not correctly computed for SegmentTimeline
dashdemux: segment timestamp not correctly computed for SegmentTimeline
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-02 14:17 UTC by Florin Apostol
Modified: 2015-09-15 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.31 KB, patch)
2015-07-02 14:19 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2015-07-02 14:17:17 UTC 
When the start of the segment is specified using SegmentTimeline element, the start must be relative to the period's start:

@t attribute in SegmentTimeline:' "specifies the MPD start time, in @timescale units, the first Segment in the series starts relative to the beginning of the Period."

But the gst_mpd_client_setup_representation function will consider @t value as being the start of the segment. We must add PeriodStart to it.
Comment 1 Florin Apostol 2015-07-02 14:19:01 UTC 
Created attachment 306625 [details] [review]
proposed patch
Comment 2 Thiago Sousa Santos 2015-07-05 19:53:35 UTC 
commit 8551f74a056b7fee2382bb7eab05fe35230ca85f
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Thu Jul 2 15:17:51 2015 +0100

    dashdemux: fixed segment start when specified by SegmentTimeline
    
    @t attribute in segment Timeline is relative to the period start.
    Corrected the code to take this into account when computing segment
    timestamp.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751841
Comment 3 A Ashley 2015-09-15 16:24:19 UTC 
Florin, did you create a unit test for this fix?
Comment 4 Florin Apostol 2015-09-15 17:11:59 UTC 
it is covered by dash_mpdparser_segment_timeline test