After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751840 - inputselector: unnecessary check is always true
inputselector: unnecessary check is always true
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-02 14:16 UTC by Luis de Bethencourt
Modified: 2015-08-16 13:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (2.12 KB, patch)
2015-07-02 14:16 UTC, Luis de Bethencourt 		committed Details | Review

Description Luis de Bethencourt 2015-07-02 14:16:14 UTC 
Created attachment 306622 [details] [review]
proposed patch

Can event ever be NULL in the check?

event has been dereferenced by GST_EVENT_TYPE (), and no case frees the pointer. I propose to remove the unnecessary check which seems to will always be True.

CID #1308955
Comment 1 Tim-Philipp Müller 2015-07-02 14:32:53 UTC 
Comment on attachment 306622 [details] [review]
proposed patch

I don't think event can be NULL there either.
Comment 2 Luis de Bethencourt 2015-07-02 15:00:24 UTC 
Review of attachment 306622 [details] [review]:

Thanks for the review Tim :)

commit c635f38cdc39b11de18ecf21e39e598435b91e7a
Author: Luis de Bethencourt <luis.bg@samsung.com>
Date:   Thu Jul 2 15:10:43 2015 +0100

    inputselector: remove always-true check

    event can't be NULL, it has been dereferenced by GST_EVENT_TYPE (), and no
    case frees the pointer. Remove unnecessary check which will always be True.

    CID #1308955