After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751800 - Warn for whitespace at beginning or end of new folder names
Warn for whitespace at beginning or end of new folder names
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2015-07-01 19:02 UTC by Arc Riley
Modified: 2015-07-05 19:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Warn for whitespace at beginning or end of new folder names (2.71 KB, patch)
2015-07-01 21:41 UTC, Arc Riley 		committed Details | Review

Description Arc Riley 2015-07-01 19:02:53 UTC 
While legal, its extremely rare that someone would want to create a new folder with whitespace at the beginning or end. More typically such whitespace is a mistake that users should be warned of.

Display a error label when entered folder names begin or end with whitespace, but leave the "Create" button active to allow this for rare cases that its actually wanted.

This is a subdivision of bug 593372
Comment 1 Arc Riley 2015-07-01 21:41:53 UTC 
Created attachment 306565 [details] [review]
Warn for whitespace at beginning or end of new folder names
Comment 2 Matthias Clasen 2015-07-04 23:04:27 UTC 
Review of attachment 306565 [details] [review]:

Looks good, thanks for the patch
Comment 3 Matthias Clasen 2015-07-04 23:05:08 UTC 
Attachment 306565 [details] pushed as 02b5ac9 - Warn for whitespace at beginning or end of new folder names
Comment 4 Piotr Drąg 2015-07-05 19:19:37 UTC 
These new strings are not marked for translation.
Comment 5 Piotr Drąg 2015-07-05 19:21:51 UTC 
They were marked in another commit. Sorry for the noise.