After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751774 - rtp: Copy over metas if possible
rtp: Copy over metas if possible
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-01 10:09 UTC by Sebastian Dröge (slomo)
Modified: 2015-08-16 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtp/{vp8,h264}: Copy metadata in the (de)payloader, but only the relevant ones (12.92 KB, patch)
2015-07-01 10:09 UTC, Sebastian Dröge (slomo)
none Details | Review
opus: Copy metadata in the (de)payloader, but only the relevant ones (4.13 KB, patch)
2015-07-01 10:09 UTC, Sebastian Dröge (slomo)
committed Details | Review
rtpbaseaudiopayload: Copy metadata in the (de)payloader, but only the relevant ones (3.64 KB, patch)
2015-07-01 14:25 UTC, Sebastian Dröge (slomo)
committed Details | Review
rtp: Copy metadata in the (de)payloader, but only the relevant ones (36.25 KB, patch)
2015-07-03 08:06 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2015-07-01 10:09:20 UTC
+++ This bug was initially created as a clone of Bug #742385 +++
Comment 1 Sebastian Dröge (slomo) 2015-07-01 10:09:45 UTC
Created attachment 306480 [details] [review]
rtp/{vp8,h264}: Copy metadata in the (de)payloader, but only the relevant ones

The payloader didn't copy anything so far, the depayloader copied every
possible meta. Let's make it consistent and just copy all metas without
tags or with only the video tag.
Comment 2 Sebastian Dröge (slomo) 2015-07-01 10:09:57 UTC
Created attachment 306481 [details] [review]
opus: Copy metadata in the (de)payloader, but only the relevant ones

The payloader didn't copy anything so far, the depayloader copied every
possible meta. Let's make it consistent and just copy all metas without tags or
with only the audio tag.
Comment 3 Sebastian Dröge (slomo) 2015-07-01 14:25:49 UTC
Created attachment 306524 [details] [review]
rtpbaseaudiopayload: Copy metadata in the (de)payloader, but only the relevant ones

The payloader didn't copy anything so far, the depayloader copied every
possible meta. Let's make it consistent and just copy all metas without
tags or with only the audio tag.
Comment 4 Sebastian Dröge (slomo) 2015-07-03 08:06:58 UTC
Created attachment 306682 [details] [review]
rtp: Copy metadata in the (de)payloader, but only the relevant ones

The payloader didn't copy anything so far, the depayloader copied every
possible meta. Let's make it consistent and just copy all metas without
tags or with only the video tag.
Comment 5 Sebastian Dröge (slomo) 2015-08-11 10:47:55 UTC
All pushed
Comment 6 Vadim Rutkovsky 2015-08-11 11:46:03 UTC
This breaks builds on Continuous: http://build.gnome.org/continuous/buildmaster/builds/2015/08/11/20/build/log-gst-plugins-base.txt

Sebastian, could you take a look?
Comment 7 Sebastian Dröge (slomo) 2015-08-11 11:55:04 UTC
Checking...
Comment 8 Sebastian Dröge (slomo) 2015-08-11 12:12:13 UTC
commit 8dc4bfdd0ea956088291c3d331af19881f9b287a
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Aug 11 14:10:57 2015 +0200

    rtp: Depend on the audio library