After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751765 - gnome-xkb-info: Add method to get languages from layout
gnome-xkb-info: Add method to get languages from layout
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks: 743643
 
 
Reported: 2015-07-01 03:50 UTC by Daiki Ueno
Modified: 2015-07-02 02:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-xkb-info: Add method to get languages from layout (2.37 KB, patch)
2015-07-01 03:50 UTC, Daiki Ueno 		none Details | Review
gnome-xkb-info: Add method to get languages from layout (2.60 KB, patch)
2015-07-02 01:56 UTC, Daiki Ueno 		none Details | Review

Description Daiki Ueno 2015-07-01 03:50:49 UTC 
--
This is needed for bug 743643.
Comment 1 Daiki Ueno 2015-07-01 03:50:52 UTC 
Created attachment 306464 [details] [review]
gnome-xkb-info: Add method to get languages from layout
Comment 2 Rui Matos 2015-07-01 12:27:25 UTC 
Review of attachment 306464 [details] [review]:

Other than the list type issue below, if this works for you, looks fine

::: libgnome-desktop/gnome-xkb-info.c
@@ +1039,3 @@
+    return NULL;
+
+  return g_list_copy (layout->iso639Ids);

This is a GSList, not a GList
Comment 3 Daiki Ueno 2015-07-02 01:56:29 UTC 
Created attachment 306574 [details] [review]
gnome-xkb-info: Add method to get languages from layout

--
Ugh, thanks for pointing that out.  I'll use this patch instead.
Comment 4 Daiki Ueno 2015-07-02 02:41:47 UTC 
Pushed as b1c0a99d.