GNOME Bugzilla – Bug 751746
Dap.MassStorage extension throws ArgumentNullException
Last modified: 2015-06-30 22:44:51 UTC
I just got this with master: [8 Error 20:54:16.059] Caught an exception - System.ArgumentNullException: Argument cannot be null. Parameter name: path1 (in `mscorlib') at System.IO.Path.Combine (System.String path1, System.String path2) [0x00000] in <filename unknown>:0 at Banshee.Dap.MassStorage.MassStorageDevice.get_IsNotAudioPlayerPath () [0x00016] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageDevice.cs:186 at Banshee.Dap.MassStorage.MassStorageDevice.ShouldIgnoreDevice () [0x00002] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageDevice.cs:73 at Banshee.Dap.MassStorage.MassStorageSource.DeviceInitialize (IDevice device, Boolean force) [0x00097] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:79 (Nereid:31335): GLib-CRITICAL **: Source ID 807 was not found when attempting to remove it (Nereid:31335): GLib-CRITICAL **: Source ID 733 was not found when attempting to remove it (Nereid:31335): GLib-CRITICAL **: Source ID 803 was not found when attempting to remove it (Nereid:31335): GLib-CRITICAL **: Source ID 578 was not found when attempting to remove it (Nereid:31335): GLib-CRITICAL **: Source ID 711 was not found when attempting to remove it (Nereid:31335): GLib-CRITICAL **: Source ID 579 was not found when attempting to remove it (Nereid:31335): GLib-CRITICAL **: Source ID 808 was not found when attempting to remove it [8 Error 20:54:16.583] Caught an exception - System.ArgumentNullException: Argument cannot be null. Parameter name: directory (in `Banshee.Core') at Banshee.IO.Directory.Exists (System.String directory) [0x0002e] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Core/Banshee.Core/Banshee.IO/Directory.cs:45 at Banshee.Dap.MassStorage.MassStorageSource.get_PlaylistsWritePath () [0x0003d] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:283 at Banshee.Dap.MassStorage.MassStorageSource.get_CanSyncPlaylists () [0x00002] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:345 at Banshee.Dap.MassStorage.MassStorageSource.get_PlaylistTypes () [0x0009d] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:320 at Banshee.Dap.MassStorage.MassStorageSource.AddDapProperties () [0x00101] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:140 at Banshee.Dap.MassStorage.MassStorageSource.DeviceInitialize (IDevice device, Boolean force) [0x001a8] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:114 at Banshee.Dap.DapService.FindDeviceSource (IDevice device) [0x0002c] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap/Banshee.Dap/DapService.cs:155
New run with a fix for the second exception above, causes these two: [8 Error 21:01:07.968] Caught an exception - System.ArgumentNullException: Argument cannot be null. Parameter name: path1 (in `mscorlib') at System.IO.Path.Combine (System.String path1, System.String path2) [0x00000] in <filename unknown>:0 at Banshee.Dap.MassStorage.MassStorageDevice.get_IsNotAudioPlayerPath () [0x00016] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageDevice.cs:186 at Banshee.Dap.MassStorage.MassStorageDevice.ShouldIgnoreDevice () [0x00002] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageDevice.cs:73 at Banshee.Dap.MassStorage.MassStorageSource.DeviceInitialize (IDevice device, Boolean force) [0x00097] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:79 [8 Debug 21:01:08.504] Found DAP support (Banshee.Dap.MassStorage.MassStorageSource) for device SM G130HN and Uuid /devices/pci0000:00/0000:00:14.0/usb3/3-4 Unhandled Exception: System.ArgumentNullException: Argument cannot be null. Parameter name: uri at Hyena.SafeUri..ctor (System.String uri) [0x00060] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Hyena/Hyena/Hyena/SafeUri.cs:61 at Banshee.IO.DirectoryScannerPipelineElement.ScanForFiles (System.String source, Boolean skip_hidden) [0x0000c] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Core/Banshee.Core/Banshee.IO/DirectoryScannerPipelineElement.cs:69 at Banshee.IO.DirectoryScannerPipelineElement.ProcessItem (System.String item) [0x00024] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Core/Banshee.Core/Banshee.IO/DirectoryScannerPipelineElement.cs:51 at Hyena.Collections.QueuePipelineElement`1[System.String].Processor (System.Object state) [0x000ab] in /home/knocte/Documents/Code/OpenSource/bansheeNEW/src/Hyena/Hyena/Hyena.Collections/QueuePipelineElement.cs:153 make: *** [run] Error 255
I suspect it was caused by https://git.gnome.org/browse/banshee/commit/?id=5a5cb82394519779c4ba641b7e993f4015714417 . I've committed afix in https://git.gnome.org/browse/banshee/commit/?id=2880a6e0a06521af6b30351b3f6131a7538ecc92
The fix looks about right to me. I'd sign it off if you hadn't already committed ;-) If it was an MTP device then we should add its information so the Mtp plugin handles it instead.
(In reply to Nicholas Little from comment #3) > The fix looks about right to me. I'd sign it off if you hadn't already > committed ;-) Thanks > If it was an MTP device then we should add its information so the Mtp plugin > handles it instead. Actually I realized later that I hadn't compiled the Mtp extension. Its ID is already in libmtp's database.