GNOME Bugzilla – Bug 751737
gio/tests/appmonitor test fails in 2.45.3
Last modified: 2015-07-01 10:13:04 UTC
In 4e7d22e268a4e06beb1c09585a48288c31004da5, deleting the file was moved after the assertion which checks for the changed event that results from it being deleted. This is the wrong way around and makes the assertion fail. Move the deletion back up before we check the condition. delete_app is no longer an idle callback so it can be made void. The change notification might come in when the loop isn't running now, so don't try to quit if it isn't running. In this case we'll wait for the three second timeout and the test will still pass.
Created attachment 306424 [details] [review] gio/tests/appmonitor: Delete file before checking for changed event
Review of attachment 306424 [details] [review]: Makes sense. Thanks!
Attachment 306424 [details] pushed as f2c1cfe - gio/tests/appmonitor: Delete file before checking for changed event