After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751737 - gio/tests/appmonitor test fails in 2.45.3
gio/tests/appmonitor test fails in 2.45.3
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-06-30 16:31 UTC by Iain Lane
Modified: 2015-07-01 10:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gio/tests/appmonitor: Delete file before checking for changed event (1.80 KB, patch)
2015-06-30 16:31 UTC, Iain Lane
committed Details | Review

Description Iain Lane 2015-06-30 16:31:46 UTC
In 4e7d22e268a4e06beb1c09585a48288c31004da5, deleting the file was moved
after the assertion which checks for the changed event that results from
it being deleted. This is the wrong way around and makes the assertion
fail.

Move the deletion back up before we check the condition. delete_app is
no longer an idle callback so it can be made void. The change
notification might come in when the loop isn't running now, so don't try
to quit if it isn't running. In this case we'll wait for the three
second timeout and the test will still pass.
Comment 1 Iain Lane 2015-06-30 16:31:50 UTC
Created attachment 306424 [details] [review]
gio/tests/appmonitor: Delete file before checking for changed event
Comment 2 Lars Karlitski 2015-07-01 10:12:19 UTC
Review of attachment 306424 [details] [review]:

Makes sense. Thanks!
Comment 3 Lars Karlitski 2015-07-01 10:13:00 UTC
Attachment 306424 [details] pushed as f2c1cfe - gio/tests/appmonitor: Delete file before checking for changed event