GNOME Bugzilla – Bug 751713
orientation: Initial orientation not getting set
Last modified: 2015-07-02 14:06:42 UTC
We call it too early: Jun 30 13:37:17 localhost.localdomain gnome-session[1646]: (gnome-settings-daemon:1726): orientation-plugin-WARNING **: Unable to call 'RotateTo': GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.SettingsDaemon.XRANDR was not provided by any .service files
Created attachment 306546 [details] [review] orientation: Fix orientation setting on startup This makes sure that XRandR is actually available when trying to rotate the screen during login as the GDBusProxy might have got created but the service isn't available.
Review of attachment 306546 [details] [review]: Otherwise looks good ::: plugins/orientation/gsd-orientation-manager.c @@ -189,3 @@ gint64 timestamp; - if (priv->xrandr_proxy == NULL) { This should be replaced by if (!priv->has_xrandr)
Created attachment 306620 [details] [review] orientation: Fix orientation setting on startup This makes sure that XRandR is actually available when trying to rotate the screen during login as the GDBusProxy might have got created but the service isn't available.
(In reply to Rui Matos from comment #2) > Review of attachment 306546 [details] [review] [review]: > > Otherwise looks good > > ::: plugins/orientation/gsd-orientation-manager.c > @@ -189,3 @@ > gint64 timestamp; > > - if (priv->xrandr_proxy == NULL) { > > This should be replaced by if (!priv->has_xrandr) do_xrandr_action() is only called from do_rotation(), and do_rotation() is called from orientation_lock_changed_cb() and properties_changed(). properties_changed() already has a guard, so I'll add a similar one to orientation_lock_changed_cb() instead.
Attachment 306620 [details] pushed as a5b063d - orientation: Fix orientation setting on startup