Bug 751707 - connectionDetails: Validate server address
connectionDetails: Validate server address
Status: RESOLVED INVALID
Product: polari
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2015-06-30 09:54 UTC by Bastian Ilsø
Modified: 2015-08-03 07:34 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
connectionDetails: Validate server adress (5.06 KB, patch)
2015-06-30 09:54 UTC, Bastian Ilsø 		none Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Bastian Ilsø 2015-06-30 09:54:18 UTC 
Created attachment 306380 [details] [review]
connectionDetails: Validate server adress

When a user inputs the server adress, we should verify that the address uses valid characters.

Attached patch uses some simple regex to search the server entry and alerts the user if an invalid character has been input.
Comment 1 Florian Müllner 2015-07-22 10:44:19 UTC 
I'm not really convinced to be honest - using illegal characters (which might change radically if IDN[0] takes off) doesn't strike me as a very common thing compared to typos like "irc.gonme.org" which simply cannot be caught with a regular expression.
(If we do this anyway, then you should remove '/' from allowed characters - the field expects a host name, not a URL)

[0] https://en.wikipedia.org/wiki/Internationalized_domain_name
Comment 2 Bastian Ilsø 2015-08-03 07:34:00 UTC 
ah, true. will close for now.
Note You need to log in before you can comment on or make changes to this bug.