GNOME Bugzilla – Bug 751693
[gtktimeline] Clip thumbnails not all shown / loaded on startup, until mouseover
Last modified: 2015-07-08 15:47:35 UTC
Created attachment 306361 [details] screencast See the attached screencast, made with the "0.91 motivational" sample project.
Created attachment 306379 [details] [review] video previewers: Rely on the clipped rectangle to redraw the thumbnails Instead of trying to guess based on the clip properties. It makes the code much simpler and more correct. Fixes:
Wow, pretty awesome how killing a bunch of code actually solves this issue. I don't really grasp the change (haven't studied it), but would be good for someone to peer-review this...
Attachment 306379 [details] pushed as 932c72e - video previewers: Rely on the clipped rectangle to redraw the thumbnails
commit 932c72e369a indeed fixed the problem for video thumbnails, but the problem is still present for audio waveforms (they only appear when putting the mouse over them, in that sample project)
Created attachment 307086 [details] [review] Revert "timeline: Update elements position in the size_allocate GtkWidget vmethod" The ->size_allocate vmethod is actually not called each time we draw but it is called only in certain circounstances which might lead to clip no being drawn in some conditions (especially after a project is loaded) This reverts commit b5c8a3859e2af957d0f53b1dbb6969e3c6fbb81d.
Attachment 307086 [details] pushed as a06899e - Revert "timeline: Update elements position in the size_allocate GtkWidget vmethod"