After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751693 - [gtktimeline] Clip thumbnails not all shown / loaded on startup, until mouseover
[gtktimeline] Clip thumbnails not all shown / loaded on startup, until mouseover
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Timeline
Git
Other Linux
: Normal minor
: 0.95
Assigned To: Thibault Saunier
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-30 02:20 UTC by Jean-François Fortin Tam
Modified: 2015-07-08 15:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screencast (763.45 KB, video/webm)
2015-06-30 02:20 UTC, Jean-François Fortin Tam
  Details
video previewers: Rely on the clipped rectangle to redraw the thumbnails (4.75 KB, patch)
2015-06-30 09:22 UTC, Thibault Saunier
committed Details | Review
Revert "timeline: Update elements position in the size_allocate GtkWidget vmethod" (1.25 KB, patch)
2015-07-08 15:45 UTC, Thibault Saunier
committed Details | Review

Description Jean-François Fortin Tam 2015-06-30 02:20:07 UTC
Created attachment 306361 [details]
screencast

See the attached screencast, made with the "0.91 motivational" sample project.
Comment 1 Thibault Saunier 2015-06-30 09:22:42 UTC
Created attachment 306379 [details] [review]
video previewers: Rely on the clipped rectangle to redraw the thumbnails

Instead of trying to guess based on the clip properties. It makes the
code much simpler and more correct.

Fixes:
Comment 2 Jean-François Fortin Tam 2015-06-30 21:57:05 UTC
Wow, pretty awesome how killing a bunch of code actually solves this issue.
I don't really grasp the change (haven't studied it), but would be good for someone to peer-review this...
Comment 3 Thibault Saunier 2015-07-01 09:57:46 UTC
Attachment 306379 [details] pushed as 932c72e - video previewers: Rely on the clipped rectangle to redraw the thumbnails
Comment 4 Jean-François Fortin Tam 2015-07-08 14:18:21 UTC
commit 932c72e369a indeed fixed the problem for video thumbnails, but the problem is still present for audio waveforms (they only appear when putting the mouse over them, in that sample project)
Comment 5 Thibault Saunier 2015-07-08 15:45:53 UTC
Created attachment 307086 [details] [review]
Revert "timeline: Update elements position in the size_allocate GtkWidget vmethod"

The ->size_allocate vmethod is actually not called each time we draw
but it is called only in certain circounstances which might lead to
clip no being drawn in some conditions (especially after a project is
loaded)

This reverts commit b5c8a3859e2af957d0f53b1dbb6969e3c6fbb81d.
Comment 6 Thibault Saunier 2015-07-08 15:47:31 UTC
Attachment 307086 [details] pushed as a06899e - Revert "timeline: Update elements position in the size_allocate GtkWidget vmethod"