After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751680 - patches for tiled monitor support
patches for tiled monitor support
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on: 750311
Blocks:
 
 
Reported: 2015-06-29 21:09 UTC by Dave Airlie
Modified: 2015-07-01 08:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add support for tiled monitors (3.25 KB, patch)
2015-06-29 21:13 UTC, Dave Airlie 		committed Details | Review
don't early exit loops if not primary (888 bytes, patch)
2015-06-29 21:14 UTC, Dave Airlie 		none Details | Review
fix behaviour with changing from primary to secondary and back (1.03 KB, patch)
2015-07-01 00:17 UTC, Dave Airlie 		committed Details | Review

Description Dave Airlie 2015-06-29 21:09:00 UTC 
These patches are required so the display panel shows tiled monitors as a single monitor, with the correct modes.
Comment 1 Dave Airlie 2015-06-29 21:09:23 UTC 
these depend on the gnome-desktop patches.
Comment 2 Dave Airlie 2015-06-29 21:13:38 UTC 
Created attachment 306332 [details] [review]
add support for tiled monitors
Comment 3 Dave Airlie 2015-06-29 21:14:17 UTC 
Created attachment 306333 [details] [review]
don't early exit loops if not primary

this is needed to fix the case where we switch a tiled monitor between primary and secondary and back.
Comment 4 Bastien Nocera 2015-06-30 10:43:08 UTC 
Review of attachment 306332 [details] [review]:

Need to bump the gnome-desktop requirements in configure.ac as well.
Comment 5 Bastien Nocera 2015-06-30 10:46:45 UTC 
Review of attachment 306333 [details] [review]:

> This is stopping it 

"it" what?

> display: don't break out of loop if we weren't primary

Please explain the user-facing changes here.
Comment 6 Dave Airlie 2015-07-01 00:15:25 UTC 
So I wasn't sure how you guys deal with configure.ac bumps, I suppose I have to wait until gnome-desktop gets the patches applied in a release, then bump

GNOME_DESKTOP_REQUIRED_VERSION from 3.11.3 to 3.17.x 

If so I'll have to wait until gnome-desktop gets pushed.
Comment 7 Dave Airlie 2015-07-01 00:17:44 UTC 
Created attachment 306458 [details] [review]
fix behaviour with changing from primary to secondary and back
Comment 8 Bastien Nocera 2015-07-01 08:52:19 UTC 
Committed after a few commit message changes.

I also added the version req bump.