GNOME Bugzilla – Bug 751651
Autocompletion menu doesnt working properly
Last modified: 2018-04-15 00:15:51 UTC
Created attachment 306291 [details] video.webm See, I get this when using Builder from jhbuild. I'm not sure if this is the proper place to fill it, but this is a start at least. I see two things, first on a Wayland session, the app-menu it's not working, second, the autocompletion menu isn not showing properly and it's eating my keystrokes. I have to type slowly to make it to the editor. The attached screencast show the problem. Note: None of this happens when I'm running old X session. Note: The cursor is around line 85, so you can see it easily.
What version of GTK+ are you using? I fixed autocomplete like popup positioning elsewhere (evolution), and I wonder if you have that fix in the version of GTK+ you are using.
(In reply to Jonas Ådahl from comment #1) > What version of GTK+ are you using? I fixed autocomplete like popup > positioning elsewhere (evolution), and I wonder if you have that fix in the > version of GTK+ you are using. I'm running Builder from jhbuild and so, gtk+ is from jhbuild, the commit is this one: cd3f24d5793e038ee29d780b24747707c73ad00c
(In reply to Erick Pérez Castellanos from comment #2) > (In reply to Jonas Ådahl from comment #1) > > What version of GTK+ are you using? I fixed autocomplete like popup > > positioning elsewhere (evolution), and I wonder if you have that fix in the > > version of GTK+ you are using. > > I'm running Builder from jhbuild and so, gtk+ is from jhbuild, the commit is > this one: cd3f24d5793e038ee29d780b24747707c73ad00c Ok, then it is not the same issue as was fixed before.
I investigated this a bit, and for what i can see, builder tries to map (via GtkSourceView) a GtkSourceCompletionInfo (which is a gdk window with the hint "COMBO"). Combo windows usually gets mapped, and should here as well, as "xdg_popup" on the protocol level, but fails to do so because the window is not made transient for another, meaning from GDK's point of view, it is a stand alone window with no connection to the editor. In other words, I think this needs to be fixed in builder by properly marking the combo window as a child window to the parent window, so that GDK can properly make that connection on the protocol level as well. Note that, on Wayland, this is required to allow positioning and stacknig order to work as they should. I also imagine we can do the same hack/work-around for guessing a likely transient window in a similar way we do with popup menus. Is that something we want to do in GTK+ for combo windows as well?
This can also be reproduced in the Midori browser (version 0.5.11) with GTK 3.18.1 under Mutter 3.18.0, where the autocompletion in the URL bar refuses to show up properly if running under Wayland. From what I can see in the source code, Midori uses a TreeView inside a popup window with the COMBO type hint for the URL autocompletion bar (see midori_location_action_popup_timeout_cb() in midori/midori-locationaction.c, around line 687). So it appears to be the same bug as is reported here. Given that this seems to be somewhat common in applications, I guess it's a good idea to implement the same work-around for the combo windows so that there is minimal functionality impact for the applications (they will need to be fixed properly in the long term but the workaround will allow a smoother transition)?
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
As announced a while ago, we are migrating to gitlab, and bugs that haven't seen activity in the last year or so will be not be migrated, but closed out in bugzilla. If this bug is still relevant to you, you can open a new issue describing the symptoms and how to reproduce it with gtk 3.22.x or master in gitlab: https://gitlab.gnome.org/GNOME/gtk/issues/new