GNOME Bugzilla – Bug 751647
audio/video: Copy over more metas by default
Last modified: 2018-11-03 11:39:08 UTC
For audio/video decoder/encoder/filter/etc we're currently copying all metas without tags and with audio/video tags only. We could also copy over things with e.g. the video-dimensions tag if the input and output caps are the same, or even in other cases by calling the meta's transform function.
Created attachment 306299 [details] [review] adapter: Copy over GstMeta from the input buffers to the output All functions that return a GstBuffer or a list of them will now copy all GstMeta from the input buffers except for meta with GST_META_FLAG_POOLED flag or "memory" tag. This is similar to the existing behaviour that the caller can't assume anything about the buffer flags, timestamps or other metadata.
Comment on attachment 306299 [details] [review] adapter: Copy over GstMeta from the input buffers to the output Wrong bug :)
As discussed on IRC, elements should do the following: - If all tags of a meta are known, and known to not be affected by whatever the element does, then the COPY transform should be called - Otherwise one or more non-COPY transform that correspond to whatever the element does should be called on the meta We will need to add more meta transforms, and probably also more tags. Also videocrop/roi are currently having wrong tags or incomplete tags at least: video, video-size. However the size can stay the same but still the meta can become invalid, e.g. when keeping the size but cropping+scaling the content.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/204.