After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751591 - epiphany-3.16.2: tests are not always run on /tmp
epiphany-3.16.2: tests are not always run on /tmp
Status: RESOLVED INCOMPLETE
Product: epiphany
Classification: Core
Component: Build
3.16.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-27 16:32 UTC by Pacho Ramos
Modified: 2016-01-13 04:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
1.patch (972 bytes, patch)
2015-06-27 16:32 UTC, Pacho Ramos
reviewed Details | Review

Description Pacho Ramos 2015-06-27 16:32:17 UTC
Created attachment 306202 [details] [review]
1.patch

We are needing to apply the attached patch downstream on Gentoo because tests run in ${PORTAGE_TMPDIR} is not guaranteed to be /tmp... maybe the logic should take care about this case too :/

Thanks a lot for your help
Comment 1 Pacho Ramos 2015-06-27 16:43:07 UTC
We get this failure otherwise:
TEST: test-ephy-file-helpers... (pid=1856)
  /lib/ephy-file-helpers/init:                                         
** (test-ephy-file-helpers:1856): WARNING **: INIT: dangerous path returned as tmp_dir: /var/tmp/portage/www-client/epiphany-3.16.2/temp/epiphany-portage-BSWpsM
FAIL
GTester: last random seed: R02Sb7a2f67c3125c9d1209bfcfcde9b4db9
/bin/sh: line 1:  1766 Terminated              G_DEBUG=gc-friendly MALLOC_CHECK_=2 MALLOC_PERTURB_=$((${RANDOM:-256} % 256)) gtester --verbose test-ephy-bookmarks test-ephy-completion-model test-ephy-download test-ephy-embed-shell test-ephy-embed-utils test-ephy-encodings test-ephy-file-helpers test-ephy-history test-ephy-location-entry test-ephy-migration test-ephy-snapshot-service test-ephy-sqlite test-ephy-string ephy-uri-helpers-test test-ephy-web-app-utils test-ephy-web-view
Makefile:1190: recipe for target 'test-nonrecursive' failed
make[3]: *** [test-nonrecursive] Error 143
make[3]: Leaving directory '/var/tmp/portage/www-client/epiphany-3.16.2/work/epiphany-3.16.2/tests'
Makefile:1055: recipe for target 'check-am' failed
make[2]: *** [check-am] Error 2
make[2]: Leaving directory '/var/tmp/portage/www-client/epiphany-3.16.2/work/epiphany-3.16.2/tests'
Makefile:907: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/www-client/epiphany-3.16.2/work/epiphany-3.16.2/tests'
Makefile:468: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1
Comment 2 Michael Catanzaro 2015-06-30 16:16:17 UTC
Review of attachment 306202 [details] [review]:

Instead of completely removing the check, how about just making sure that tmp_dir is not / before deleting it. There would have to be a horrible bug for that to be the case, but it seems like a good thing to test.
Comment 3 Michael Catanzaro 2016-01-13 04:28:24 UTC
Hi, I am closing all Epiphany bugs currently in the NEEDINFO state. If you can provide the requested information or you feel this bug was closed in error, please leave a comment. Thanks!