After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751583 - "You have obtained the $v tile" don't looks as template
"You have obtained the $v tile" don't looks as template
Status: RESOLVED FIXED
Product: gnome-2048
Classification: Other
Component: general
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-2048 maintainer(s)
gnome-2048 maintainer(s)
: 758607 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-06-27 11:39 UTC by Igor Gnatenko
Modified: 2016-01-18 21:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (967 bytes, patch)
2015-12-26 20:50 UTC, Robert Roth
committed Details | Review

Description Igor Gnatenko 2015-06-27 11:39:14 UTC
I got 2048 block, but I see "$v" instead of value.

    _game.target_value_reached.connect ((s, v) => {
      if (_settings.get_boolean ("do-congrat")) {
        string message = @_("You have obtained the $v tile");
        _congrats_message.set_text (message);
        _congrats_dialog.present ();
        _settings.set_boolean ("do-congrat", false);
      }
      debug ("target value reached");
    });

Probably it should be something like _(@"You have obtained the $v tile");

I'm not expert in Vala.
Comment 1 Robert Roth 2015-12-25 20:58:07 UTC
*** Bug 758607 has been marked as a duplicate of this bug. ***
Comment 2 Robert Roth 2015-12-26 20:50:21 UTC
Created attachment 317905 [details] [review]
Proposed patch