GNOME Bugzilla – Bug 751556
geary-0.10.0: stop appending CFLAGS
Last modified: 2016-04-03 12:57:33 UTC
Created attachment 306179 [details] [review] geary-cflags.patch We are needing to carry a patch downstream at Gentoo for a long time to prevent build scripts from forcing some CFLAGS (like -O2 or -g) Maybe it could be considered for being upstreamed finally
Sadly, being able to run geary under a debugger is frequently necessary. We're not going to remove it unconditionally. It'd be reasonable to only use the -g flag when DEBUG is set, though. I don't know how important the optimization flag is, offhand.
Hi Pacho, Is this still an issue for Gentoo? Per Robert's comment, a patch that adds -g only when DEBUG is set (i.e. the opposite of the conditional in the above) would be good, and especially if you could back it up with some timings then we could possibly drop the -O2.
Well, it's not a problem for us as we carry the patch for not changing the FLAG and, instead, rely on users using proper CFLAGS for each case (for example, for debugging purposes, we ask them to rebuild with -g and other flags like -ggdb or dropping optimization flags like -O3... - https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Backtraces )
Okay, well if you're happy to maintain the patch downstream then I'll close this as WONTFIX for now. If that becomes annoying please do reopen this and I'll be happy to consider a patch that works as outlined in comment #2.