After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751546 - gl: gst_gl_context_destroy is unused
gl: gst_gl_context_destroy is unused
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-26 15:27 UTC by Xavier Claessens
Modified: 2015-07-08 03:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gl: remove unused code (2.39 KB, patch)
2015-06-26 15:27 UTC, Xavier Claessens 		reviewed Details | Review

Description Xavier Claessens 2015-06-26 15:27:39 UTC 
Better remove unused public API while we still can.
Comment 1 Xavier Claessens 2015-06-26 15:27:58 UTC 
Created attachment 306177 [details] [review]
gl: remove unused code
Comment 2 Sebastian Dröge (slomo) 2015-06-28 10:17:05 UTC 
Comment on attachment 306177 [details] [review]
gl: remove unused code

Why do you think we should remove that? The vfunc is implemented by all backends it seems, and probably gst_gl_context_create_thread() should just call that function in the end instead of just calling the vfunc?

However I'm not sure how useful it is to have this vfunc public, not sure what exactly will happen if someone calls it on a still running context. Probably crashes
Comment 3 Xavier Claessens 2015-06-29 13:34:17 UTC 
Just saw that it's never used, and the vfunc is called internally so I don't see why you would need it to be public. But it's cosmetic, feel free to close WONTFIX ;-)
Comment 4 Matthew Waters (ystreet00) 2015-07-08 03:38:49 UTC 
Bad things will mostly likely happen if destroy_context is called while other's are using the context.  Currently refcounting the context takes care of destroying the context when necessary.  When the extra GL thread is removed from GstGLWindow as a result of bug #704809, there will be use for an explicit destroy_context() as the mirror to create_context() in the brave new world.