GNOME Bugzilla – Bug 751503
Cannot move/split/save terminal
Last modified: 2015-07-07 19:17:13 UTC
Created attachment 306115 [details] screenshot of big terminal with broken move/split/save options Working with the terminal plugin in the bottom frame, I can press Ctrl+Shift+T to open a big terminal in the normal editor view (screenshot attached). I was pretty surprised to discover that, but I guess you'll have a more discoverable way to do this in the future? Anyway, this big terminal has the same split, move, and save operations as normal text documents, but nothing happens when I click on them. They should be insensitive or not present. It would be nice to implement Move, though.
Created attachment 306662 [details] [review] fix spit and move This patch need https://bugzilla.gnome.org/show_bug.cgi?id=751834 to work like expected. There's still some issues already there before the patch: - When closing Gb with an open terminal we get : GLib[8101]: WARNING: GChildWatchSource: Exit status of a child process was requested but ECHILD was received by waitpid(). Most likely the process is ignoring SIGCHLD, or some other thread is invoking waitpid() with a nonpositive first argument; either behavior can break applications that use g_child_watch_add()/g_spawn_sync() either directly or indirectly. - I also haven't test the needs-attention provide by OSC 777 command as patches for this are not committed yet : https://bugzilla.gnome.org/show_bug.cgi?id=711059 - When moving views (terminal, editor, Devhelp) to the left we get : CRITICAL: gtk_window_get_default_widget: assertion 'GTK_IS_WINDOW (window)' failed CRITICAL: gtk_window_set_default: assertion 'GTK_IS_WINDOW (window)' failed
what about save/save as ? we can do it by saving the focused view when having a vertical split.
Review of attachment 306662 [details] [review]: ::: plugins/terminal/gb-terminal-view.c @@ -229,1 +271,13 @@ - + if (position == GTK_POS_TOP && + !gtk_widget_in_destruction (GTK_WIDGET (self->terminal_top))) + { ... 10 more ... i have forgotten this one
Created attachment 306851 [details] [review] GbTerminalView: add split and move
Created attachment 306855 [details] [review] GbTerminalView: save and save-as Terminal views now support save (it do a save-as if you never saved it before) and save-as. The saved terminal is the focused one. The whole terminal backlog history is saved, unless there's a selection, in this case, the selection is saved.
what's missing so far: - <ctrl>s - highlight ( blue border like focused entry ? ) focused terminal, so we can clearly see the one to save. - progress bar: not sure it's worth the code as it almost always small files.
We also need cut/copy/paste handling too
LGTM, lets get this merged.
Attachment 306851 [details] pushed as 7484f85 - GbTerminalView: add split and move Attachment 306855 [details] pushed as 89869c8 - GbTerminalView: save and save-as