GNOME Bugzilla – Bug 751496
rtspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property
Last modified: 2015-08-16 13:36:52 UTC
Recently, ntp-time-source is added to rtpbin/rtpsession. Also this new property needs to be added to rtspsrc.
Created attachment 306102 [details] [review] rtspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property I'm not sure whether it's correct that set FALSE to use-pipeline-clock once nth-time-source is set.
Created attachment 306114 [details] [review] rtpbin/session: fix description
Review of attachment 306102 [details] [review]: ::: gst/rtsp/gstrtspsrc.c @@ +3423,3 @@ + g_object_set (src->manager, "use-pipeline-clock", FALSE, NULL); + } + } The code a few lines above is still always setting use-pipeline-clock to something. I think the logic should be like in rtpbin: if (src->use_pipeline_clock) { g_object_set (manager, "use-pipeline-clock", TRUE, NULL); } else { g_object_set (manager, "ntp-time-source", src->ntp_time_source, NULL); }
Created attachment 306116 [details] [review] rtpbin/session: fix descriptiontspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property Following slum's review.
Comment on attachment 306116 [details] [review] rtpbin/session: fix descriptiontspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property commit f560a3d223d5623fc184d8a2a62cb8bbc295d11b Author: Hyunjun Ko <zzoon.ko@samsung.com> Date: Fri Jun 26 00:05:29 2015 +0900 rtspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property Enable to use new ntp-time-source property of rtpbin https://bugzilla.gnome.org/show_bug.cgi?id=751496
commit f560a3d223d5623fc184d8a2a62cb8bbc295d11b Author: Hyunjun Ko <zzoon.ko@samsung.com> Date: Fri Jun 26 00:05:29 2015 +0900 rtspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property Enable to use new ntp-time-source property of rtpbin https://bugzilla.gnome.org/show_bug.cgi?id=751496