After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751493 - Place details popup appearing above the window
Place details popup appearing above the window
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2015-06-25 11:35 UTC by Zeeshan Ali
Modified: 2015-06-30 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the issue (1.41 MB, image/png)
2015-06-25 11:40 UTC, Zeeshan Ali
  Details
mapMarker: Use Gdk.Rectangle (1.63 KB, patch)
2015-06-28 18:38 UTC, Damián Nohales
committed Details | Review

Description Zeeshan Ali 2015-06-25 11:35:34 UTC
See screenshot
Comment 1 Zeeshan Ali 2015-06-25 11:40:23 UTC
Created attachment 306093 [details]
Screenshot of the issue
Comment 2 Zeeshan Ali 2015-06-25 11:44:03 UTC
This is against git master of everything in jhbuild btw.
Comment 3 Damián Nohales 2015-06-28 18:38:39 UTC
Created attachment 306246 [details] [review]
mapMarker: Use Gdk.Rectangle

Maps was throwing errors when trying to assign a Cairo.RectangleInt to
GtkPopover.pointing_to property, the weird thing is what change (in gjs
or whatever component) caused this problem.

It's also weird that, if I remember correctly, I was unable to create
Gdk.Rectangle objects in gjs since it's not a GObject class, but
a cairo_rectangle_int_t alias.
Comment 4 Jonas Danielsson 2015-06-29 05:36:33 UTC
Review of attachment 306246 [details] [review]:

Looks fine.
Comment 5 Jonas Danielsson 2015-06-29 05:38:19 UTC
(In reply to Damián Nohales from comment #3)
> Created attachment 306246 [details] [review] [review]
> mapMarker: Use Gdk.Rectangle
> 
> Maps was throwing errors when trying to assign a Cairo.RectangleInt to
> GtkPopover.pointing_to property, the weird thing is what change (in gjs
> or whatever component) caused this problem.
> 
> It's also weird that, if I remember correctly, I was unable to create
> Gdk.Rectangle objects in gjs since it's not a GObject class, but
> a cairo_rectangle_int_t alias.

Probably this?

https://git.gnome.org/browse/gtk+/commit/?id=724cc00f9baa8a808195eebfea686cef1d63d12c
Comment 6 Damián Nohales 2015-06-29 13:07:34 UTC
(In reply to Jonas Danielsson from comment #5)
> Probably this?
> 
> https://git.gnome.org/browse/gtk+/commit/
> ?id=724cc00f9baa8a808195eebfea686cef1d63d12c

Eureka!
Comment 7 Damián Nohales 2015-06-30 22:28:44 UTC
Attachment 306246 [details] pushed as 8bc74ec - mapMarker: Use Gdk.Rectangle