GNOME Bugzilla – Bug 751472
Don't create libinput properties
Last modified: 2015-07-07 15:05:37 UTC
Created attachment 306063 [details] [review] 0001-x11-don-t-create-the-libinput-tapping-property.patch clutter checks for the libinput Tapping property, but in the process creates the property (not on the device, just in the global lookup table). This confuses other layers of the stack that have similar checks - once mutter runs the property exists (not on the device, but in the global atom table). Example for this confusion (though this one doesn't seem to be clutter's fault): https://bugzilla.redhat.com/show_bug.cgi?id=1199825
Review of attachment 306063 [details] [review]: Pretty sure GDK does the same thing, since the code comes from a similar commit there: https://git.gnome.org/browse/gtk+/commit/?id=6f07d5e761f2c1d18825f73033ab7d095ea2c70d Makes sense, though.
Adding Carlos to the Cc list.
hah, thanks. I was trying to figure out where that last instance came from :)
Doh, mea culpa for all of these. The patch looks good to me, if you don't get to doing a GTK+ one, I'll do tomorrow.
Carlos: I'll leave it to you for the GTK+ one, it's not as straightforward as this one and you'll know better what will break :)
Pushed to master and to the clutter-1.22 branch, and it's included in the 1.22.4 stable release. Thanks!