After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751471 - Don't create libinput properties
Don't create libinput properties
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-06-24 23:45 UTC by Peter Hutterer
Modified: 2015-06-27 04:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-input-settings-x11-don-t-create-non-existing-atoms.patch (1.60 KB, patch)
2015-06-24 23:45 UTC, Peter Hutterer
committed Details | Review

Description Peter Hutterer 2015-06-24 23:45:27 UTC
Created attachment 306062 [details] [review]
0001-input-settings-x11-don-t-create-non-existing-atoms.patch

Mutter uses a bunch of libinput properties for configuration and bails out if they don't exist on the device. But both get_property() and change_property() *create* the atom if it doesn't exist yet.

This confuses other layers of the stack that have similar checks - once mutter runs the property exists (not on the device, but in the global atom table).

Example for this confusion (though this one doesn't seem to be mutter's fault):
https://bugzilla.redhat.com/show_bug.cgi?id=1199825
Comment 1 Jasper St. Pierre (not reading bugmail) 2015-06-25 00:12:43 UTC
Review of attachment 306062 [details] [review]:

OK.
Comment 2 Jasper St. Pierre (not reading bugmail) 2015-06-27 04:57:24 UTC
Pushed.