After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751470 - encodebin: Fix special case.
encodebin: Fix special case.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-24 21:59 UTC by Mathieu Duponchelle
Modified: 2015-10-02 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
encodebin: Fix special case. (1.52 KB, patch)
2015-06-24 21:59 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2015-06-24 21:59:06 UTC 
Allows to run such a command line :

gst-launch-1.0 uridecodebin uri=file:///home/meh/Music/sthg.mp4 ! \
encodebin profile-string="audio/x-wav|1" ! filesink location=sthg.wav

Previously the code failed because wavenc is considered as a muxer.
We still want encodebin to audio/x-wav as an AudioEncodingProfile,
so this simple fix allows that.

Ability to mux raw streams in containers such as matroskamux
is a different issue.
Comment 1 Mathieu Duponchelle 2015-06-24 21:59:11 UTC 
Created attachment 306058 [details] [review]
encodebin: Fix special case.
Comment 2 Thibault Saunier 2015-06-25 07:33:35 UTC 
Review of attachment 306058 [details] [review]:

Looks good.
Comment 3 Thibault Saunier 2015-08-27 08:58:13 UTC 
Can't this kind of bug fixing go into the release?
Comment 4 Sebastian Dröge (slomo) 2015-08-27 09:06:12 UTC 
Why was it not pushed in the last 2 months? If you think this is safe and solves an important problem, please merge it.
Comment 5 Sebastian Dröge (slomo) 2015-10-02 14:26:13 UTC 
commit 0c0f80348801cea5f190e6b2024f4c0da5381efd
Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Date:   Wed Jun 24 23:55:35 2015 +0200

    encodebin: Fix special case
    
    Allows to run such a command line :
    
    gst-launch-1.0 uridecodebin uri=file:///home/meh/Music/sthg.mp4 ! \
    encodebin profile-string="audio/x-wav|1" ! filesink location=sthg.wav
    
    Previously the code failed because wavenc is considered as a muxer.
    We still want encodebin to audio/x-wav as an AudioEncodingProfile,
    so this simple fix allows that.
    
    Ability to mux raw streams in containers such as matroskamux
    is a different issue.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751470