After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751456 - 'move to' moves the file 'to' but not 'delete' the origin
'move to' moves the file 'to' but not 'delete' the origin
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
: 756332 762262 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-06-24 18:53 UTC by Herbert Parentes Fortes Neto
Modified: 2016-02-18 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Herbert Parentes Fortes Neto 2015-06-24 18:53:20 UTC
Hi,

"The option "move to" does copy the files from one folder to another, but does
not delete the original files."


regards,
Herbert
Comment 1 Hans Deragon 2015-09-03 08:44:14 UTC
Very annoying bug.  I am using version 3.4.0.  Also, once fixed, the operation should perform a true "mv" is the files remain in the same filesystem. Copy and delete should only be performed when moving files across different filesystems.

None of the developers notice this bug?  Should be easy to fix by simply looking into the old code and revert to what was done before.  It used to work.
Comment 2 ragelt 2015-12-07 10:14:45 UTC
Waiting for fix!
Comment 3 Michael Chudobiak 2015-12-16 13:22:25 UTC
*** Bug 756332 has been marked as a duplicate of this bug. ***
Comment 4 Michael Chudobiak 2015-12-16 14:12:48 UTC
Fixed by commit d2998dd99a0d3d2edba98d70fae97efb87008111
Comment 5 Hans Deragon 2015-12-16 15:04:30 UTC
I checked the code committed.  copy_selected_files_to_folder(), does it perform a mv if the files reside the same filesystem? (preferred)  Or does it copy and delete?

Thanks for the fix.  Still better having copy/delete (if such is the case) than nothing.
Comment 6 Michael Chudobiak 2015-12-16 15:38:17 UTC
I don't know - I believe it relies on g_file_move:

https://developer.gnome.org/gio/stable/GFile.html#g-file-move
Comment 7 Herbert Parentes Fortes Neto 2016-02-17 15:25:35 UTC
Hi,

I was waiting for a new version. But can I apply
this fix to current version - 3:3.4.1 ?


Regards
Comment 8 Michael Chudobiak 2016-02-17 15:30:47 UTC
Of course. You can compile from the latest git master version too, explained here: https://wiki.gnome.org/Apps/gthumb/development
Comment 9 Michael Chudobiak 2016-02-18 14:08:13 UTC
*** Bug 762262 has been marked as a duplicate of this bug. ***