After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751445 - playbin: try to auto-load subtitles
playbin: try to auto-load subtitles
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-24 14:14 UTC by Víctor Manuel Jáquez Leal
Modified: 2018-11-03 11:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playbin: try to auto-load subtitles (2.62 KB, patch)
2015-06-24 14:14 UTC, Víctor Manuel Jáquez Leal 		rejected Details | Review

Description Víctor Manuel Jáquez Leal 2015-06-24 14:14:38 UTC 
As a result of the discussion in bug #745292, this patch enables the same
functionality but in the playbin itself.
Comment 1 Víctor Manuel Jáquez Leal 2015-06-24 14:14:43 UTC 
Created attachment 306006 [details] [review]
playbin: try to auto-load subtitles

If suburi is not set, and the media uri protocol is file, a file with same
name as the media file but with subtitle extension is looked. If it is found,
it is used as suburi.
Comment 2 Sebastian Dröge (slomo) 2015-06-24 14:18:23 UTC 
Not sure if this shouldn't rather stay an application decision.
Comment 3 Philippe Normand 2018-07-01 09:33:57 UTC 
(In reply to Sebastian Dröge (slomo) from comment #2)
> Not sure if this shouldn't rather stay an application decision.

Or perhaps a new GstPlayer API?
Comment 4 Thibault Saunier 2018-07-01 13:35:52 UTC 
(In reply to Philippe Normand from comment #3)
> (In reply to Sebastian Dröge (slomo) from comment #2)
> > Not sure if this shouldn't rather stay an application decision.
> 
> Or perhaps a new GstPlayer API?

I would say that it should either be totally transparent as implemented in this patch or implemented by applications, I do not think extra API should be added for that.

Is anyone against that patch? It sounds pretty useful to me.
Comment 5 Philippe Normand 2018-07-02 08:18:00 UTC 
Playbin unconditionally setting the suburi itself would have side effects, you don't always want to do that, like in WebKit for instance.
Comment 6 Sebastian Dröge (slomo) 2018-07-02 10:24:13 UTC 
Same as Philippe, I don't think this should be done automatically. There should be API for this to opt-in into this behaviour, and it closely relates to loading other external resources. Edward had some plans for that in playbin3, IIRC also API proposals.
Comment 7 GStreamer system administrator 2018-11-03 11:38:28 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/197.