After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751336 - Don't allow changing the sort order in the recent view
Don't allow changing the sort order in the recent view
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: All
3.17.x
Other Linux
: Normal normal
: 3.18
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-22 16:26 UTC by Allan Day
Modified: 2015-09-01 09:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
files-view: remove unused header (882 bytes, patch)
2015-09-01 09:01 UTC, Carlos Soriano
committed Details | Review
list-view: disable sorting on recent and search (3.00 KB, patch)
2015-09-01 09:01 UTC, Carlos Soriano
committed Details | Review
files-view: make sure sort values correcteness (8.35 KB, patch)
2015-09-01 09:01 UTC, Carlos Soriano
none Details | Review
files-view: ensure sort criteria correcteness (8.35 KB, patch)
2015-09-01 09:02 UTC, Carlos Soriano
committed Details | Review

Description Allan Day 2015-06-22 16:26:19 UTC
The recent view serves one purpose - to show recent files. The sort order of the view is implicit in the name.

It therefore makes no sense to allow changing the sort order in this view, either when it is in grid or list mode.

Changing the sort order actually equates to breaking the view, since the UI doesn't actually let you switch it back to the original sort order.
Comment 1 Carlos Soriano 2015-06-27 17:01:04 UTC
Removed the sort section in Recent then?
Comment 2 Allan Day 2015-06-29 10:44:06 UTC
(In reply to Carlos Soriano from comment #1)
> Removed the sort section in Recent then?

That would work for the grid view. For list view, we could either hide the column headers entirely, or make them insensitive.
Comment 3 Matthias Clasen 2015-06-29 15:14:30 UTC
Technically, making the columns not sortable is separate from 'sensitive'. You can still interact with column headers in various ways (resize, drag, open context menu,...).
Comment 4 Allan Day 2015-07-07 14:19:16 UTC
This change has now landed in the file chooser - it would be good if nautilus were consistent.
Comment 5 Carlos Soriano 2015-09-01 09:01:09 UTC
Created attachment 310400 [details] [review]
files-view: remove unused header
Comment 6 Carlos Soriano 2015-09-01 09:01:14 UTC
Created attachment 310401 [details] [review]
list-view: disable sorting on recent and search

Following what we did in the canvas view, and what the file
chooser is doing, we disallow the manual sorting on recent
and search for list view as well, since it kinda defeats the
point to allow a diferent sorting in those situations.

However, for search we can still want some different sorting,
but let's try this way and also be consistent with filechooser.
Comment 7 Carlos Soriano 2015-09-01 09:01:20 UTC
Created attachment 310402 [details] [review]
files-view: make sure sort values correcteness

Since last commit it's not allowed o change the sort criteria
on search and recent, but the user could changed it before updating
nautilus or some application could modified the metadata itself,
making the user incapable to set the correct values.
To fix that, override at runtime the sort criterion for recent and
search, but withouth modifying the metadata.
Comment 8 Carlos Soriano 2015-09-01 09:02:01 UTC
Created attachment 310403 [details] [review]
files-view: ensure sort criteria correcteness

Since last commit it's not allowed o change the sort criteria
on search and recent, but the user could changed it before updating
nautilus or some application could modified the metadata itself,
making the user incapable to set the correct values.
To fix that, override at runtime the sort criterion for recent and
search, but withouth modifying the metadata.
Comment 9 Carlos Soriano 2015-09-01 09:26:49 UTC
Attachment 310400 [details] pushed as 166a392 - files-view: remove unused header
Attachment 310401 [details] pushed as 223d57c - list-view: disable sorting on recent and search
Attachment 310403 [details] pushed as 0779b55 - files-view: ensure sort criteria correcteness