After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751319 - souphttpsrc: does not work on windows xp
souphttpsrc: does not work on windows xp
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Windows
: Normal blocker
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-22 12:26 UTC by Fabio Cetrini
Modified: 2015-08-16 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (7.63 KB, patch)
2015-07-02 15:22 UTC, Nicola
committed Details | Review

Description Fabio Cetrini 2015-06-22 12:26:10 UTC
On Window XP, any pipelines using souphttpsrc stuck on ready->paused transition.
Sometimes, gst_soup_http_src_parse_status returns "The requested address is not valid in its context", most often the connection simply goes timeout by server.
The bug is NOT present in 1.4.5.
Comment 1 Sebastian Dröge (slomo) 2015-06-22 12:34:22 UTC
My guess would be that this is a bug in libsoup, 1.4.5 and 1.5.1 have different versions of libsoup. Can you check if the examples from the libsoup code are working for you?
Comment 2 Tim-Philipp Müller 2015-06-22 12:42:31 UTC
Does this only affect XP?
Comment 3 Fabio Cetrini 2015-06-22 14:10:30 UTC
Yes Tim, no problem on windows 7/8/10
Comment 4 Fabio Cetrini 2015-06-22 15:39:56 UTC
(In reply to Sebastian Dröge (slomo) from comment #1)
> My guess would be that this is a bug in libsoup, 1.4.5 and 1.5.1 have
> different versions of libsoup. Can you check if the examples from the
> libsoup code are working for you?

Sebastian, I've made gstreamer cross-compilation using cerbero, how can I test libsoup examples?
Comment 5 Sebastian Dröge (slomo) 2015-06-26 09:32:39 UTC
In sources/window*/libsoup*/examples you should have the examples ready to run


I think it's just time to drop Windows XP support, GLib is going to spew a g_warning() all the time because we build with Windows XP support anyway.
Comment 6 Tim-Philipp Müller 2015-06-26 09:58:09 UTC
Certainly not a release blocker IMHO.
Comment 7 Tim-Philipp Müller 2015-06-26 10:00:41 UTC
Setting NEEDINFO until we know whether it's a libsoup issue or a GStreamer issue.
Comment 8 Fabio Cetrini 2015-06-26 11:57:43 UTC
I've tested get.exe under windows xp, it seems that the request does not exit at all, no incoming connection arrives server side.
No problem under windows 7 instead.

Sebastian, I would agree with you about windows xp support, but unfortunately we still have several customers with these old machines...
Comment 9 Sebastian Dröge (slomo) 2015-06-26 15:11:33 UTC
I think it doesn't make sense for us to continue providing binaries for Windows XP and below as many important features are not possible with that. And I'm not talking about libsoup here. Especially because we still build for Windows XP, GLib has no way to initialize its random number generator from a proper entropy source, and since 2.44 or something also warns about that all the time.


Nothing will prevent you from building for older versions, but there's not much interest in spending more time on making things work for older versions. GLib also dropped (or will drop) official Windows XP support soonish (if it hasn't already).
Comment 10 Sebastian Dröge (slomo) 2015-06-26 15:12:42 UTC
Note that because we build for Windows XP, *nobody* can use newer Windows features with our builds and everybody has to suffer because of the few Windows XP users still out there.
Comment 11 Nicola 2015-07-01 12:59:14 UTC
Hi Fabio,

can you please try this patch?

https://git.gnome.org/browse/glib/commit/?h=glib-2-44&id=675dbae3029ff95d94cdbd513906c98e1ad767ad

the problem seems inside glib and not specific to libsoup
Comment 12 Nicola 2015-07-01 13:29:05 UTC
probably also these ones are needed:

https://bugzilla.gnome.org/show_bug.cgi?id=749911
https://bugzilla.gnome.org/show_bug.cgi?id=749912
Comment 13 Fabio Cetrini 2015-07-02 06:54:52 UTC
Thanks Nicola, the patched glib solves the issue, bug closed for me.
Comment 14 Nicola 2015-07-02 07:04:28 UTC
(In reply to Fabio Cetrini from comment #13)
> Thanks Nicola, the patched glib solves the issue, bug closed for me.

Ok thanks for the feedback, so, as summary, the needed patch are these ones:

https://git.gnome.org/browse/glib/commit/?h=glib-2-44&id=675dbae3029ff95d94cdbd513906c98e1ad767ad

https://git.gnome.org/browse/glib/commit/?id=a4c3ab58ccf32b0f50ce6f78fa7d18ee5745d510

https://git.gnome.org/browse/glib/commit/?id=f9af40a1330a8226d72c96bff56cdb4ab895dac7
Comment 15 Sebastian Dröge (slomo) 2015-07-02 07:06:05 UTC
So let's backport them in cerbero
Comment 16 Nicola 2015-07-02 07:27:32 UTC
(In reply to Sebastian Dröge (slomo) from comment #15)
> So let's backport them in cerbero

Do you want a patch or proceed yourself?
Comment 17 Sebastian Dröge (slomo) 2015-07-02 08:59:43 UTC
Please send a (tested) patch if you can :)
Comment 18 Nicola 2015-07-02 15:22:33 UTC
Created attachment 306637 [details] [review]
proposed fix

I have no way to test this patch,

Fabio can you please confirm that the produced dll works for you?

You can download the produced gio dll, 64 bit version, here:

http://195.250.34.59/temp/libgio-2.0-0.dll
Comment 19 Nicola 2015-07-02 16:00:09 UTC
(In reply to Nicola from comment #18)
> Created attachment 306637 [details] [review] [review]
> proposed fix
> 
> I have no way to test this patch,
> 
> Fabio can you please confirm that the produced dll works for you?
> 
> You can download the produced gio dll, 64 bit version, here:
> 
> http://195.250.34.59/temp/libgio-2.0-0.dll

oops, I realized now that maybe is not so common to have windows xp 64 bit ...
Comment 20 Nicola 2015-07-02 21:42:49 UTC
here is the 32bit dll

http://195.250.34.59/temp/32/libgio-2.0-0.dll
Comment 21 Fabio Cetrini 2015-07-03 06:44:25 UTC
Hi Nicola, the libgio you provided solves, thank you
Comment 22 Sebastian Dröge (slomo) 2015-07-06 08:58:00 UTC
commit 3021ad7f0c6cc33be424d5fbc95fa07812547fb1
Author: Nicola Murino <nicola.murino@gmail.com>
Date:   Thu Jul 2 17:14:19 2015 +0200

    glib: fix windows xp compatibility
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751319