After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751245 - Clip margins of adjacent clips have 1px between them sometimes
Clip margins of adjacent clips have 1px between them sometimes
Status: RESOLVED OBSOLETE
Product: pitivi
Classification: Other
Component: Timeline
Git
Other Linux
: Normal minor
: 0.95
Assigned To: Alex Băluț
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-20 05:28 UTC by Alex Băluț
Modified: 2015-10-20 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
timeline (40.96 KB, image/png)
2015-06-20 05:28 UTC, Alex Băluț 		  Details
elements: Reuse computed values when saving state (2.17 KB, patch)
2015-07-08 10:31 UTC, Alex Băluț 		none Details | Review
elements: Remove margins between clips (1.29 KB, patch)
2015-07-08 10:31 UTC, Alex Băluț 		accepted-commit_now Details | Review

Description Alex Băluț 2015-06-20 05:28:52 UTC 
Created attachment 305735 [details]
timeline

Just add a bunch of clips and look at the timeline. See the attachment for an example.
Comment 1 Alex Băluț 2015-06-26 20:59:11 UTC 
This seems to be a regression. It has been fixed before, see:

https://git.gnome.org/browse/pitivi/commit/?id=d9ea4348ac41a7e87888d93039f680634efeeccd
Comment 2 Alex Băluț 2015-07-08 10:31:23 UTC 
Created attachment 307063 [details] [review]
elements: Reuse computed values when saving state
Comment 3 Alex Băluț 2015-07-08 10:31:28 UTC 
Created attachment 307064 [details] [review]
elements: Remove margins between clips

Fixes
Comment 4 Thibault Saunier 2015-07-08 13:03:03 UTC 
Review of attachment 307063 [details] [review]:

Why do you do that
Comment 5 Thibault Saunier 2015-07-08 13:03:15 UTC 
Review of attachment 307064 [details] [review]:

OK
Comment 6 Thibault Saunier 2015-07-08 13:03:17 UTC 
Review of attachment 307064 [details] [review]:

OK
Comment 7 Alex Băluț 2015-07-08 13:29:10 UTC 
(In reply to Thibault Saunier from comment #4)
> Review of attachment 307063 [details] [review] [review]:
> 
> Why do you do that

Code looks better and works the same. Plus, the logic in the next commit is used now in a single place.
Comment 8 Thibault Saunier 2015-10-20 13:21:41 UTC 
This bug has been migrated to https://phabricator.freedesktop.org/T3292.

Please use the Phabricator interface to report further bugs by creating a task and associating it with Project: Pitivi.

See http://wiki.pitivi.org/wiki/Bug_reporting for details.