GNOME Bugzilla – Bug 751229
tests: Fixes for 3.17 UI changes
Last modified: 2016-09-20 08:15:55 UTC
preferences can be access just from right click menu not from bottom panel in 3.17.
Created attachment 305704 [details] [review] tests: Open properties via right click menu All steps accessing properties dialog are now using right click menu instead of bottom panel button as it was removed.
Comment on attachment 305704 [details] [review] tests: Open properties via right click menu Attachment 305704 [details] pushed as 470ffc8 - tests: Open properties via right click menu with slight modification to description. So did I understand correctly that this patche makes all tests pass on git master now?
(In reply to Zeeshan Ali (Khattak) from comment #2) > Comment on attachment 305704 [details] [review] [review] > tests: Open properties via right click menu > > Attachment 305704 [details] pushed as 470ffc8 - tests: Open properties via > right click menu > > with slight modification to description. So did I understand correctly that > this patche makes all tests pass on git master now? yes, I made full run without express installations and it passed.
hmm, there is one fail now in vnc: we've used vnc://localhost:5901; but now we have to use vnc://localhost:5901 without semicolon. Is it a bug or wanted behaviour?
(In reply to vladimir benes from comment #3) > (In reply to Zeeshan Ali (Khattak) from comment #2) > > Comment on attachment 305704 [details] [review] [review] [review] > > tests: Open properties via right click menu > > > > Attachment 305704 [details] pushed as 470ffc8 - tests: Open properties via > > right click menu > > > > with slight modification to description. So did I understand correctly that > > this patche makes all tests pass on git master now? > > yes, I made full run without express installations and it passed. Ah ok so it doesn't fix all of them so I'll keep the bug open. (In reply to vladimir benes from comment #4) > hmm, there is one fail now in vnc: > we've used vnc://localhost:5901; > > but now we have to use vnc://localhost:5901 without semicolon. > > Is it a bug or wanted behaviour? I don't see why semicolon would be part of URL so i'd guess a bug fix in gtk-vnc? Please ask danpb on IRC. I don't think anything in Boxes changes in this regard.
Created attachment 308294 [details] [review] Fix prints for new behave New behave requires bracketed print instead of quoted only.
Created attachment 308295 [details] [review] Remove semicolon from vnc tests
Created attachment 308296 [details] [review] Change Memory label name "Memory" label name in Customize Resources tab is now "Memory: ".
Created attachment 308302 [details] [review] tests: Change link to Fedora 20 image Change location of DVD image to archive location as Fedora 20 is now considered an archive version.
Created attachment 308303 [details] [review] tests: Change "Memory" label name "Memory" label name in Customize Resources tab is now "Memory: ".
Created attachment 308304 [details] [review] tests: Remove semicolon from vnc tests
Created attachment 308305 [details] [review] tests: Fix prints for new behave New behave requires bracketed print instead of quoted only.
seems to be complete. all tests pass. review needed :-)
Created attachment 308306 [details] [review] tests: Remove Continue click after New Click on Continue button at introduction page is not needed anymore. The page was removed.
ok, this was the last one.
Review of attachment 308294 [details] [review]: * Shortlog should describe the change, not effect * print is not quoted, its the passed string. I'll just write "New behave requires brackets in print calls." * Would be even better if log mentions what 'new' means.
Review of attachment 308305 [details] [review]: I don't know what the diff with the previous version that I just reviewed but same comments apply. :)
Review of attachment 308302 [details] [review]: "Change" -> "Update". Good otherwise.
Review of attachment 308303 [details] [review]: * "Change" -> "Update". * "Customize Resources tab" -> ""Customize Resources" view" Good otherwise.
Review of attachment 308304 [details] [review]: * Some explanation would be nice. Was it never really needed? Why remove it now? * "vnc" -> "VNC"
Review of attachment 308306 [details] [review]: Good but can be slightly improved: * "The" -> "The introduction". * "removed" -> "removed recently"
Created attachment 308329 [details] [review] tests: Remove semicolon from VNC tests Semicolon is not used anymore at the end of vnc:// location. This was very likely a bug in previous tests.
Created attachment 308330 [details] [review] tests: Remove semicolon from VNC tests Semicolon is not used anymore at the end of vnc:// location. This was very likely a bug in previous tests.
Created attachment 308332 [details] [review] tests: Update "Memory" label name "Memory" label name in Customize Resources view is now "Memory: ".
Created attachment 308333 [details] [review] tests: Update link to Fedora 20 image Update location of DVD image to archive location as Fedora 20 is now considered an archive version.
Created attachment 308334 [details] [review] tests: Add brackets to print calls New version of Behave requires brackets in print calls.
Review of attachment 308330 [details] [review]: * It sounds like semicolon was "used" before and now it's not. * "previous tests"? I assume you meant to say that this was a mistake/typo in existing code. I'll fix the description for you before pushing..
Attachment 308306 [details] pushed as 77cb3f0 - tests: Remove Continue click after New Attachment 308330 [details] pushed as f113290 - tests: Remove semicolon from VNC URLs
Review of attachment 308332 [details] [review]: ack
Review of attachment 308333 [details] [review]: ack
Review of attachment 308334 [details] [review]: ack
Attachment 308332 [details] pushed as 2f347e4 - tests: Update "Memory" label name Attachment 308333 [details] pushed as 198a187 - tests: Update link to Fedora 20 image Attachment 308334 [details] pushed as 7131d7a - tests: Add brackets to print calls