After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751228 - texParameterf missing?
texParameterf missing?
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-19 15:09 UTC by john
Modified: 2015-06-23 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
texparameterf added to gst-libs/gst/gl/glprototypes/base.h (12.56 KB, patch)
2015-06-23 04:25 UTC, john 		committed Details | Review

Description john 2015-06-19 15:09:23 UTC 
in the opengl support in bad-plugins, the glTexParameterf call is not available.  glTexParameteri, glTexParameteriv, and glTexParameterfv are all available.  is there some particular reason this call was not exposed, or is this just an oversight?

thanks
Comment 1 Sebastian Dröge (slomo) 2015-06-22 12:16:17 UTC 
No reason AFAIK, want to provide a patch to add it?
Comment 2 john 2015-06-22 17:14:15 UTC 
i'm not currently enlisted as a gstreamer developer but will get on that.

in the meantime, the change is simple.  in gst-plugins-bad/gst-libs/gl/glprototypes/base.h, add the following function declaration at line 181 (or earlier if you are not concerned about table reordering)

GST_GL_EXT_FUNCTION (void, TexParameterf,
                     (GLenum target,
                      GLenum pname,
                      GLfloat param))

i've been building with this for 3 days and seems to work fine.
Comment 3 Sebastian Dröge (slomo) 2015-06-22 20:03:51 UTC 
You don't have to get enlisted anywhere, if you provide a patch here in this bug report I'll merge it :)
Comment 4 john 2015-06-23 04:25:29 UTC 
Created attachment 305885 [details] [review]
texparameterf added to gst-libs/gst/gl/glprototypes/base.h

Missing TexParameterf entry point added to base.h
Comment 5 Sebastian Dröge (slomo) 2015-06-23 08:30:23 UTC 
Comment on attachment 305885 [details] [review]
texparameterf added to gst-libs/gst/gl/glprototypes/base.h

That's not really a patch by I merged it now anyway :)

For the future, do your changes, git commit them locally and then use git format-patch to get a patch file.
Comment 6 Sebastian Dröge (slomo) 2015-06-23 08:32:32 UTC 
commit 1ece34af2cda3cfe2bbd2d69e6fbf6bea696b098
Author: John Ludwig <john@theludwigs.com>
Date:   Tue Jun 23 10:31:44 2015 +0200

    gl: Include texParameterf in the GL function table
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751228
Comment 7 john 2015-06-23 14:52:41 UTC 
thanks for taking the fix, and thanks for the patch tutorial, i'm a patch noob!  very much appreciate all the work you do...