After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751102 - Fix -Werror build for clang
Fix -Werror build for clang
Status: RESOLVED FIXED
Product: GUPnP
Classification: Other
Component: any
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-17 10:20 UTC by Ting-Wei Lan
Modified: 2015-06-17 13:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fix missing prototype warning for clang (791 bytes, patch)
2015-06-17 10:33 UTC, Ting-Wei Lan 		rejected Details | Review
build: Use -Wno-unused-parameter instead of -Wno-unused-parameters (840 bytes, patch)
2015-06-17 10:36 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2015-06-17 10:20:41 UTC 
Please see the patches. I will attach two patches here.
Comment 1 Ting-Wei Lan 2015-06-17 10:33:21 UTC 
Created attachment 305467 [details] [review]
build: Fix missing prototype warning for clang
Comment 2 Ting-Wei Lan 2015-06-17 10:36:27 UTC 
Created attachment 305468 [details] [review]
build: Use -Wno-unused-parameter instead of -Wno-unused-parameters

Clang doesn't support -Wno-unused-parameters. We should use the option
supported by both GCC and Clang.
Comment 3 Jens Georg 2015-06-17 10:40:03 UTC 
Review of attachment 305467 [details] [review]:

This was committed 20minutes ago by someone else, sorry.
Comment 4 Jens Georg 2015-06-17 10:40:21 UTC 
Review of attachment 305468 [details] [review]:

+1
Comment 5 Ting-Wei Lan 2015-06-17 13:35:31 UTC 
Attachment 305468 [details] pushed as c7ee091 - build: Use -Wno-unused-parameter instead of -Wno-unused-parameters