After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751087 - nalutils: trivial cleanup
nalutils: trivial cleanup
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
Other Linux
: Normal minor
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2015-06-17 01:44 UTC by Vineeth
Modified: 2015-06-17 08:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

trivial cleanup (1.13 KB, patch)
2015-06-17 01:45 UTC, Vineeth
committed Details | Review

Description Vineeth 2015-06-17 01:44:07 UTC
trivial patch to add proper ( while checking for if(G_UNLIKELY())
Comment 1 Vineeth 2015-06-17 01:45:12 UTC
Created attachment 305446 [details] [review]
trivial cleanup
Comment 2 Nicolas Dufresne (ndufresne) 2015-06-17 02:08:23 UTC
Comment 3 Tim-Philipp Müller 2015-06-17 08:12:38 UTC
For future reference, a commit message like this would have been better:

 nalutils: trivial cleanup

instead of

 nalutils: patch to check if

(everyone reading this knows it's a commit already, i.e. a patch; you're not checking anything that's already checked; an if clause by definition is a check; so really this description doesn't tell anyone anything :) "cleanup" tells people it's only a style change or some other small change)