After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751083 - [regression] when starting a mail in plaintext and switching to HTML, HTML signatures are borked and do not have line returns
[regression] when starting a mail in plaintext and switching to HTML, HTML si...
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Composer
3.16.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Tomas Popela
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2015-06-17 00:17 UTC by Jean-François Fortin Tam
Modified: 2016-08-15 13:02 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2015-06-17 00:17:06 UTC
Have an account with a signature such as:

    <b>John Doe</b>
    <a href="http://example.com">ACME inc.</a>

    La la la


…with the Evolution global mail preferences set to not create HTML mails by default. Then, create a new mail (ctrl+shift+M). Notice that the mail starts with the signature, but in plaintext and with *no line breaks*, so it looks like:

    John Doe ACME inc. La la la

If, in the composer, you then switch to HTML mode, instead of getting the signature converted to its HTML version (like it used to do in Evolution 3.12 and earlier) you still get the plaintext version.

As a workaround, switching to another signature and back to this one, while now in HTML mode, makes it work again.
Comment 1 c.kirbach 2015-06-19 10:45:40 UTC
Yes, I see the same issue here.

evolution.x86_64   3.16.3-2.fc22
Comment 2 André Klapper 2015-07-01 12:46:15 UTC
Maybe related: I replied in plain text mode to a long nested HTML message. After sending my reply and going to the Sent folder, all linebreaks in that message were removed. 
The last four lines became:

Cheers,andre-- 
Andre Klapper
Comment 3 Tomas Popela 2015-07-03 09:29:21 UTC
(In reply to Jean-François Fortin Tam from comment #0)
> Have an account with a signature such as:
> 
>     <b>John Doe</b>
>     <a href="http://example.com">ACME inc.</a>
> 
>     La la la
> 
> 
> …with the Evolution global mail preferences set to not create HTML mails by
> default. Then, create a new mail (ctrl+shift+M). Notice that the mail starts
> with the signature, but in plaintext and with *no line breaks*, so it looks
> like:
> 
>     John Doe ACME inc. La la la

That's expected (try to load the code in i.e. Firefox). Otherwise the signature's HTML code should be inside the PRE tag.

> 
> If, in the composer, you then switch to HTML mode, instead of getting the
> signature converted to its HTML version (like it used to do in Evolution
> 3.12 and earlier) you still get the plaintext version.

Yes, that's because we really don't know if the user edited the signature, so we leave it as it is. If you want the HTML version you have to indeed use the "workaround" as you suggested.
Comment 4 Tomas Popela 2015-07-03 09:30:29 UTC
(In reply to André Klapper from comment #2)
> Maybe related: I replied in plain text mode to a long nested HTML message.
> After sending my reply and going to the Sent folder, all linebreaks in that
> message were removed. 
> The last four lines became:
> 
> Cheers,andre-- 
> Andre Klapper

I doubt it is related. Please open a new bug report with reproducer and clear step by step instructions how to reproduce it.
Comment 5 David Woodhouse 2015-07-16 14:50:26 UTC
(In reply to André Klapper from comment #2)
> Maybe related: I replied in plain text mode to a long nested HTML message.
> After sending my reply and going to the Sent folder, all linebreaks in that
> message were removed. 

Any bug along the lines of "what I was looking at on-screen before I hit 'send' does not match what I found in my Sent folder' is basically a symptom of bug 752166 and should be marked as a duplicate thereof.

It's not entirely clear to me if the original part of this bug report is one of those or not.
Comment 6 Adam Williamson 2016-03-08 17:58:24 UTC
I'm now seeing something that looks the same when just creating mails with the plain text composer, no mode switch involved at all. See all my recent mails to public lists, making me look like a putz who doesn't know how to format a .sig. :/ e.g.:

http://lists.fedoraproject.org/archives/list/test@lists.fedoraproject.org/message/RM44MGLOY236SJYSTECEQNRBO3HQF566/

this is a recent break, I think it broke in 3.19.91-1.
Comment 7 Jean-François Fortin Tam 2016-03-09 01:27:05 UTC
> That's expected (try to load the code in i.e. Firefox).
> Otherwise the signature's HTML code should be inside the PRE tag.

Well okay, my example should have had <br/> there, I should have said:


    <b>John Doe</b><br/>
    <a href="http://example.com">ACME inc.</a><br/>
    <br/>
    La la la


...I just didn't think of writing that in my explanation, it's implicit (how would the workaround ever work without them, anyway?)

I suppose Evolution needs to somehow always keep the signature portion in HTML internally, behind the scenes... dunno if webkit interprets the line breaks differently from gtkhtml or if those linebreaks get stripped somewhere in the process, but the point is, I'm pretty sure this used to work fine in previous versions...
Comment 8 Tomas Popela 2016-03-09 06:11:49 UTC
(In reply to Adam Williamson from comment #6)
> I'm now seeing something that looks the same when just creating mails with
> the plain text composer, no mode switch involved at all. See all my recent
> mails to public lists, making me look like a putz who doesn't know how to
> format a .sig. :/ e.g.:
> 
> http://lists.fedoraproject.org/archives/list/test@lists.fedoraproject.org/
> message/RM44MGLOY236SJYSTECEQNRBO3HQF566/
> 
> this is a recent break, I think it broke in 3.19.91-1.

I already told you on IRC, that it will be fixed in the next version. I already have a WIP patch for that.
Comment 9 Adam Williamson 2016-03-09 06:23:47 UTC
Well, you said you'd take a look at it, but I didn't hear anything else so I thought I'd better mention it in a bug report, is all.
Comment 10 Tomas Popela 2016-08-15 13:02:06 UTC
This is already fixed in master.