After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751073 - Bump gtk+3 to 3.16
Bump gtk+3 to 3.16
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
unspecified
Other Linux
: Normal normal
: git master
Assigned To: Thibault Saunier
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-16 20:06 UTC by Xavier Claessens
Modified: 2015-06-25 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Set ACLOCAL_PATH when use_system_libs=True (797 bytes, patch)
2015-06-16 20:19 UTC, Xavier Claessens
none Details | Review
Add libepoxy.recipe (2.36 KB, patch)
2015-06-16 20:19 UTC, Xavier Claessens
none Details | Review
Bump atk to 2.16 and gtk+3 to 3.16 (2.01 KB, patch)
2015-06-16 20:19 UTC, Xavier Claessens
none Details | Review
preserve ACLOCAL_PATH value with use-system-libs (1.07 KB, patch)
2015-06-25 15:50 UTC, Xavier Claessens
none Details | Review

Description Xavier Claessens 2015-06-16 20:06:03 UTC
New gtkglsink code needs gtk >= 3.15.0
Comment 1 Xavier Claessens 2015-06-16 20:19:02 UTC
Created attachment 305427 [details] [review]
Set ACLOCAL_PATH when use_system_libs=True
Comment 2 Xavier Claessens 2015-06-16 20:19:06 UTC
Created attachment 305428 [details] [review]
Add libepoxy.recipe
Comment 3 Xavier Claessens 2015-06-16 20:19:10 UTC
Created attachment 305429 [details] [review]
Bump atk to 2.16 and gtk+3 to 3.16
Comment 4 Thibault Saunier 2015-06-17 07:45:18 UTC
Thanks for that Xavier, I needed it to start using gtkglsink in pitivi :)

The patches look good but if you want to make sure that the gtkglsink plugins is build you will need to add in the plugins-bad recipe a dep on gtk if the gtk3 variant is activated.
Comment 5 Thibault Saunier 2015-06-17 08:33:15 UTC
I am finishing it.
Comment 6 Thibault Saunier 2015-06-17 09:05:04 UTC
Attachment 305427 [details] pushed as 97d1bcc - Set ACLOCAL_PATH when use_system_libs=True
Attachment 305428 [details] pushed as 9f4606e - Add libepoxy.recipe
Attachment 305429 [details] pushed as 85f7087 - Bump atk to 2.16 and gtk+3 to 3.16
Comment 7 Sebastian Dröge (slomo) 2015-06-22 10:45:27 UTC
You only added it to gst-plugins-bad-1.0.recipe, not the static one. Intentional?
Comment 8 Thibault Saunier 2015-06-22 10:54:14 UTC
I was not sure, and Gtk only build on Linux at that point. I am not sure the static recipes are used on linux?

Also, I was wondering if it would not be possible to merge those static recipes into the others and activate on demand or something?
Comment 9 Sebastian Dröge (slomo) 2015-06-22 10:58:49 UTC
They are used on Linux, and you generally want to build static and non-static plugins. However moving the static plugin build into our autotools build system would be a good idea, so that we don't have to build things twice.
Comment 10 Thibault Saunier 2015-06-22 11:41:33 UTC
For the record I activated it for the -static recipe too:

commit 714cad1db7bf26b69574a5e3f140772b7a64f2d1
Author: Thibault Saunier <tsaunier@gnome.org>
Date:   Mon Jun 22 13:37:48 2015 +0200

    recipes: Enable gtksink for plugins-bad static build
Comment 11 Xavier Claessens 2015-06-25 15:50:47 UTC
Created attachment 306118 [details] [review]
preserve ACLOCAL_PATH value with use-system-libs
Comment 12 Xavier Claessens 2015-06-25 15:54:50 UTC
This is a fix for attachment #305427 [details] for the case ACLOCAL_PATH was already set.
Comment 13 Thibault Saunier 2015-06-25 15:59:11 UTC
Attachment 306118 [details] pushed as 6e8f097 - preserve ACLOCAL_PATH value with use-system-libs