GNOME Bugzilla – Bug 751027
validateelements: removed redundant test cases and covered more elements
Last modified: 2018-11-03 11:07:07 UTC
Validateelements generates redundant test cases for element. It is creating test case for each property with default value. Test cases for element with multiple properties with default value are the redundant test cases. Instead of generating test case for each property with default value, generate only one test case with DEFAULT behavior.
Created attachment 305365 [details] [review] validateelements: removed redundant test cases and covered more elements Redundant test cases removed by generating only single test case for default behavior. Also covering more element by allowing DEFAULT test case for elements with no numeric or boolean properties. Creating more test cases by covering float values.
Review of attachment 305365 [details] [review]: Thanks for the patch. Also please make sure you code is pep8 complient, I have noticed some little issues here and there. ::: testsuites/validateelements.py @@ +35,3 @@ GObject.TYPE_UINT, GObject.TYPE_UINT64, GObject.TYPE_LONG, GObject.TYPE_ULONG, + GObject.TYPE_DOUBLE, GObject.TYPE_FLOAT] That change is unrelated, please make another commit. @@ -104,2 +90,3 @@ ("validate.launch_pipeline.glfilterbin*", "glfilter bin doesnt launch."), + ("validate.launch_pipeline.glmosaic*", This is completely unrelated afaict. Please try to open bug reports when it is a bug, or be more specific about why it is not working (if it is normal it does not work). @@ +176,3 @@ + if test_count > 0: + element_count = element_count + 1 + #print "Element %20s TestCases: %2d" % (fname, test_count) Please remove that line. @@ +178,3 @@ + #print "Element %20s TestCases: %2d" % (fname, test_count) + + print "Total %4d testcases generated for %4d elements" % (total_test_cases,element_count) And that one too.
Created attachment 305381 [details] [review] validateelements: removed redundant test cases and covered more elements please review updated patch. Putting glmosaic and glvideomixerelement in blacklist as it has multiple on request sinkpads. glfilterbin failed to connect to these filters in simple pipeline.
please review the updated patch
ping
Hi Thibault, please review this.
please review this patch
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-devtools/issues/16.